You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by Tibor17 <gi...@git.apache.org> on 2018/03/11 07:52:08 UTC
[GitHub] maven-surefire pull request #176: [SUREFIRE-1495] Encoding of TXT report fil...
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/176
[SUREFIRE-1495] Encoding of TXT report file should be configured by ${project.reporting.outputEncoding} and MOJO parameter encoding
Related to JIRA [SUREFIRE-1495](https://issues.apache.org/jira/browse/SUREFIRE-1495).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/maven-surefire SUREFIRE-1495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit c496ebf3b4518c25787d5eac9f54b2a220a59447
Author: Tibor17 <ti...@...>
Date: 2018-03-08T07:19:02Z
[SUREFIRE-1495] Encoding of TXT report file should be configured by ${project.reporting.outputEncoding} and MOJO parameter encoding
----
---
[GitHub] maven-surefire pull request #176: [SUREFIRE-1495] Encoding of TXT report fil...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/176#discussion_r173648023
--- Diff: surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java ---
@@ -171,4 +172,9 @@ public static void assumeJavaVersion( double expectedVersion )
assumeTrue( "java.specification.version: " + thisVersion,
Double.valueOf( thisVersion ) >= expectedVersion );
}
+
+ public static String toUTF8( String unicode )
--- End diff --
maybe the name is not explaining the purpose of the function
---
[GitHub] maven-surefire pull request #176: [SUREFIRE-1495] Encoding of TXT report fil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-surefire/pull/176
---
[GitHub] maven-surefire pull request #176: [SUREFIRE-1495] Encoding of TXT report fil...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/176#discussion_r173648002
--- Diff: surefire-its/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java ---
@@ -62,14 +65,13 @@ public void checkFileNamesWithUnicode()
unpacked.executeTest()
.assertTestSuiteResults( 2, 0, 0, 0 );
- TestFile surefireReportFile = outputValidator.getSurefireReportsFile( TXT_REPORT );
+ TestFile surefireReportFile = outputValidator.getSurefireReportsFile( TXT_REPORT, UTF_8 );
assertTrue( surefireReportFile.exists() );
- surefireReportFile.assertContainsText( "junit.twoTestCases.????Test" );
+ surefireReportFile.assertContainsText( toUTF8( REPORT_FILE_CONTENT ) );
--- End diff --
@Tibor17 isnt's obvious that
toUTF8( REPORT_FILE_CONTENT ) not equals(REPORT_FILE_CONTENT)
IMHO we could write a comment to explain why this toUTF8 is needed, or add a
assertNotEquals(REPORT_FILE_CONTENT, toUTF8( REPORT_FILE_CONTENT ))
---
[GitHub] maven-surefire issue #176: [SUREFIRE-1495] Encoding of TXT report file shoul...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/176
@eolivelli
done. I did git commit amend so you have to clone the repo again.
---