You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/26 09:55:22 UTC

[GitHub] [shardingsphere] jiangML opened a new pull request, #17119: Modify SCHEMA_KEY to DATABASE_KEY

jiangML opened a new pull request, #17119:
URL: https://github.com/apache/shardingsphere/pull/17119

   For https://github.com/apache/shardingsphere/issues/14004   https://github.com/apache/shardingsphere/pull/16336
   
   Changes proposed in this pull request:
   - Modify SCHEMA_KEY to DATABASE_KEY
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on pull request #17119: Modify SCHEMA_KEY to DATABASE_KEY

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #17119:
URL: https://github.com/apache/shardingsphere/pull/17119#issuecomment-1109804054

   @jiangML Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17119: Modify SCHEMA_KEY to DATABASE_KEY

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17119:
URL: https://github.com/apache/shardingsphere/pull/17119#discussion_r858649572


##########
docs/document/content/user-manual/shardingsphere-proxy/logging/_index.en.md:
##########
@@ -3,44 +3,44 @@ title = "Logging"
 weight = 4
 +++
 
-This chapter will introduce the detailed syntax of Logging which is used when users need to distinguish schemas or users in the log. To achieve a specific goal, following configurations can be added to logback.xml:
+This chapter will introduce the detailed syntax of Logging which is used when users need to distinguish database or users in the log. To achieve a specific goal, following configurations can be added to logback.xml:
 
-## To distinguish schemas in the same log
+## To distinguish database in the same log
 ```
-<appender name="schemaConsole" class="ch.qos.logback.core.ConsoleAppender">
+<appender name="databaseConsole" class="ch.qos.logback.core.ConsoleAppender">
     <encoder>
-        <pattern>[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} [%thread] [%X{schema}] %logger{36} - %msg%n</pattern>
+        <pattern>[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} [%thread] [%X{database}] %logger{36} - %msg%n</pattern>
     </encoder>
 </appender>
 
 <logger name="ShardingSphere-SQL" level="info" additivity="false">
-    <appender-ref ref="schemaConsole" />
+    <appender-ref ref="databaseConsole" />
 </logger>
 ```
 
-## To distinguish schemas and users in the same log
+## To distinguish database and users in the same log

Review Comment:
   `databases`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang merged pull request #17119: Modify SCHEMA_KEY to DATABASE_KEY

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #17119:
URL: https://github.com/apache/shardingsphere/pull/17119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17119: Modify SCHEMA_KEY to DATABASE_KEY

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17119:
URL: https://github.com/apache/shardingsphere/pull/17119#discussion_r858647726


##########
docs/document/content/user-manual/shardingsphere-proxy/logging/_index.en.md:
##########
@@ -3,44 +3,44 @@ title = "Logging"
 weight = 4
 +++
 
-This chapter will introduce the detailed syntax of Logging which is used when users need to distinguish schemas or users in the log. To achieve a specific goal, following configurations can be added to logback.xml:
+This chapter will introduce the detailed syntax of Logging which is used when users need to distinguish database or users in the log. To achieve a specific goal, following configurations can be added to logback.xml:

Review Comment:
   `databases` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org