You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2025/03/12 18:13:41 UTC

(superset) 01/01: fix(sqllab): Allow clear on schema and catalog (#32515)

This is an automated email from the ASF dual-hosted git repository.

jli pushed a commit to branch 4.1
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 735552e79511f7fb74ef574da536952153a8533a
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Fri Mar 7 13:28:05 2025 -0800

    fix(sqllab): Allow clear on schema and catalog (#32515)
    
    (cherry picked from commit 4c3aae7583fd1fec034574894c766d9466610927)
---
 superset-frontend/src/components/DatabaseSelector/index.tsx | 2 ++
 superset/commands/dataset/importers/v1/utils.py             | 1 +
 2 files changed, 3 insertions(+)

diff --git a/superset-frontend/src/components/DatabaseSelector/index.tsx b/superset-frontend/src/components/DatabaseSelector/index.tsx
index 321d753bc5..0f1b6aa30c 100644
--- a/superset-frontend/src/components/DatabaseSelector/index.tsx
+++ b/superset-frontend/src/components/DatabaseSelector/index.tsx
@@ -392,6 +392,7 @@ export default function DatabaseSelector({
         options={catalogOptions}
         showSearch
         value={currentCatalog || undefined}
+        allowClear
       />,
       refreshIcon,
     );
@@ -418,6 +419,7 @@ export default function DatabaseSelector({
         options={schemaOptions}
         showSearch
         value={currentSchema}
+        allowClear
       />,
       refreshIcon,
     );
diff --git a/superset/commands/dataset/importers/v1/utils.py b/superset/commands/dataset/importers/v1/utils.py
index b28ecd89f8..e4dbdfe8f1 100644
--- a/superset/commands/dataset/importers/v1/utils.py
+++ b/superset/commands/dataset/importers/v1/utils.py
@@ -102,6 +102,7 @@ def validate_data_uri(data_uri: str) -> None:
     raise DatasetForbiddenDataURI()
 
 
+# pylint: disable=too-many-branches
 def import_dataset(
     config: dict[str, Any],
     overwrite: bool = False,