You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jcchavezs (via GitHub)" <gi...@apache.org> on 2023/08/10 20:15:54 UTC

[GitHub] [skywalking-go] jcchavezs commented on a diff in pull request #90: chore: updates actions to improves CI times and resource management.

jcchavezs commented on code in PR #90:
URL: https://github.com/apache/skywalking-go/pull/90#discussion_r1290634609


##########
.github/workflows/publish-docker.yaml:
##########
@@ -35,9 +35,19 @@ jobs:
     env:
       VERSION: ${{ github.sha }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           submodules: true
+      - name: Setup Golang
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.18
+      - name: Pull deps for tools/go-agent

Review Comment:
   Small trick here, we pull deps for tools/go-agent which internally uses the dep cache and then package it into vendor module which allows to be reused in the docker build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org