You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Richard S. Hall (JIRA)" <ji...@apache.org> on 2010/09/23 20:22:32 UTC

[jira] Created: (FELIX-2619) [Framework] Bundle cache implementation could do a better job of avoiding disk access

[Framework] Bundle cache implementation could do a better job of avoiding disk access
-------------------------------------------------------------------------------------

                 Key: FELIX-2619
                 URL: https://issues.apache.org/jira/browse/FELIX-2619
             Project: Felix
          Issue Type: Improvement
          Components: Framework
    Affects Versions: framework-3.0.3
            Reporter: Richard S. Hall
            Assignee: Richard S. Hall
            Priority: Minor
             Fix For: framework-3.2.0


The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (FELIX-2619) [Framework] Bundle cache is rechecking non-existing files again and again

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2619:
-----------------------------------

    Summary: [Framework] Bundle cache is rechecking non-existing files again and again  (was: [Framework] Bundle cache implementation could do a better job of avoiding disk access)

> [Framework] Bundle cache is rechecking non-existing files again and again
> -------------------------------------------------------------------------
>
>                 Key: FELIX-2619
>                 URL: https://issues.apache.org/jira/browse/FELIX-2619
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.3
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: framework-3.2.0
>
>
> The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (FELIX-2619) [Framework] Bundle cache is rechecking nonexistent files again and again

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2619:
-----------------------------------

    Fix Version/s: framework-3.0.4
                       (was: framework-3.2.0)

> [Framework] Bundle cache is rechecking nonexistent files again and again
> ------------------------------------------------------------------------
>
>                 Key: FELIX-2619
>                 URL: https://issues.apache.org/jira/browse/FELIX-2619
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.3
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: framework-3.0.4
>
>
> The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (FELIX-2619) [Framework] Bundle cache implementation could do a better job of avoiding disk access

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall closed FELIX-2619.
----------------------------------

    Resolution: Fixed

I committed some improvements to fix the most obvious cases.

> [Framework] Bundle cache implementation could do a better job of avoiding disk access
> -------------------------------------------------------------------------------------
>
>                 Key: FELIX-2619
>                 URL: https://issues.apache.org/jira/browse/FELIX-2619
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.3
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: framework-3.2.0
>
>
> The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (FELIX-2619) [Framework] Bundle cache is rechecking nonexistent files again and again

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917739#action_12917739 ] 

Richard S. Hall commented on FELIX-2619:
----------------------------------------

Patch 1003559 was rolled back for now.

> [Framework] Bundle cache is rechecking nonexistent files again and again
> ------------------------------------------------------------------------
>
>                 Key: FELIX-2619
>                 URL: https://issues.apache.org/jira/browse/FELIX-2619
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.3
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: framework-3.0.4
>
>
> The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (FELIX-2619) [Framework] Bundle cache is rechecking nonexistent files again and again

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2619:
-----------------------------------

    Summary: [Framework] Bundle cache is rechecking nonexistent files again and again  (was: [Framework] Bundle cache is rechecking non-existing files again and again)

> [Framework] Bundle cache is rechecking nonexistent files again and again
> ------------------------------------------------------------------------
>
>                 Key: FELIX-2619
>                 URL: https://issues.apache.org/jira/browse/FELIX-2619
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.3
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: framework-3.2.0
>
>
> The bundle archive implementation tries to limit disk accesses by only reading variables from the disk the first time and the caching the result. In some cases, though, it is not too smart. Like in BundleArchive.getRefreshCount() where it checks if a file exists and if not then simply returns the default value. This means all default values will incur a disk access to check for file existence. It should cache the default value after first read too, to avoid future disk accesses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.