[jira] [Commented] (MINIFI-296) More configurable logging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023488#comment-16023488 ] 

ASF GitHub Bot commented on MINIFI-296:
---------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/104

    MINIFI-296 - Configurable logging, spdlog 0.13.0

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] - N/A - If applicable, have you updated the LICENSE file?
    - [X] - N/A - If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [X] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi-cpp MINIFI-296

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit fa0304cd48920a1d3b259b9a51a6aff0c79a88e7
Author: Bryan Rosander <br...@apache.org>
Date:   2017-05-11T19:42:54Z

    MINIFI-296 - Configurable logging, spdlog 0.13.0

----


> More configurable logging
> -------------------------
>
>                 Key: MINIFI-296
>                 URL: https://issues.apache.org/jira/browse/MINIFI-296
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>            Reporter: marco polo
>            Assignee: Bryan Rosander
>            Priority: Minor
>
> The logging functionality would be more useful if it could be tuned on a per-class basis.  This would allow us to set more detailed log levels for a place where trouble is suspected while reducing noise from other areas.
> Composable log appenders would allow us to have multiple sinks so that we would have a log appender that could "phone home" with information while concurrently logging to disk. Using a processor to do the same may be too onerous; however, it stands to reason that we may use the processor as the delivery mechanism, so we may eventually negate this issue entirely if it is decided that we should ship the log itself via a processor. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)