You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/13 10:13:29 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4135: Remove use of blacklist/whitelist terms

rhtyd commented on a change in pull request #4135:
URL: https://github.com/apache/cloudstack/pull/4135#discussion_r469846397



##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -94,8 +94,8 @@
     ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
             "Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
 
-    static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
-            "user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+    static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,

Review comment:
       This will require an update statement for the config in upgrade path sql and may also require changes in cloudstack-doc due to config name change (here or changes from the PR)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org