You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/02/25 23:39:44 UTC

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py 

David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15293


Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................

IMPALA-9424: Add six to shell/ext-py

Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/six-1.14.0/CHANGES
A shell/ext-py/six-1.14.0/CONTRIBUTORS
A shell/ext-py/six-1.14.0/LICENSE
A shell/ext-py/six-1.14.0/MANIFEST.in
A shell/ext-py/six-1.14.0/README.rst
A shell/ext-py/six-1.14.0/setup.cfg
A shell/ext-py/six-1.14.0/setup.py
A shell/ext-py/six-1.14.0/six.py
A shell/ext-py/six-1.14.0/test_six.py
A shell/ext-py/six-1.14.0/tox.ini
M shell/packaging/requirements.txt
15 files changed, 2,563 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15293/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 06:38:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5423/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 21:10:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 17:25:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 21:10:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5412/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 18:09:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5336/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 23:45:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Feb 2020 01:37:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5338/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 00:54:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................

IMPALA-9424: Add six to shell/ext-py

Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Reviewed-on: http://gerrit.cloudera.org:8080/15293
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/six-1.14.0/CHANGES
A shell/ext-py/six-1.14.0/CONTRIBUTORS
A shell/ext-py/six-1.14.0/LICENSE
A shell/ext-py/six-1.14.0/MANIFEST.in
A shell/ext-py/six-1.14.0/README.rst
A shell/ext-py/six-1.14.0/setup.cfg
A shell/ext-py/six-1.14.0/setup.py
A shell/ext-py/six-1.14.0/six.py
A shell/ext-py/six-1.14.0/test_six.py
A shell/ext-py/six-1.14.0/tox.ini
M shell/packaging/requirements.txt
15 files changed, 2,563 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15293

to look at the new patch set (#2).

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................

IMPALA-9424: Add six to shell/ext-py

Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/six-1.14.0/CHANGES
A shell/ext-py/six-1.14.0/CONTRIBUTORS
A shell/ext-py/six-1.14.0/LICENSE
A shell/ext-py/six-1.14.0/MANIFEST.in
A shell/ext-py/six-1.14.0/README.rst
A shell/ext-py/six-1.14.0/setup.cfg
A shell/ext-py/six-1.14.0/setup.py
A shell/ext-py/six-1.14.0/six.py
A shell/ext-py/six-1.14.0/test_six.py
A shell/ext-py/six-1.14.0/tox.ini
M shell/packaging/requirements.txt
15 files changed, 2,563 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15293/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 18:09:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9424: Add six to shell/ext-py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15293 )

Change subject: IMPALA-9424: Add six to shell/ext-py
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5412/


-- 
To view, visit http://gerrit.cloudera.org:8080/15293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I003e0008c138ee1f2c290775553d4cfc66e9b7fe
Gerrit-Change-Number: 15293
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 22:38:09 +0000
Gerrit-HasComments: No