[GitHub] [airflow] jedcunningham commented on a diff in pull request #25031: added labels to airflow specific pods

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25031:
URL: https://github.com/apache/airflow/pull/25031#discussion_r951924404


##########
tests/charts/test_flower.py:
##########
@@ -280,6 +280,25 @@ def test_should_add_extraEnvs(self):
             "spec.template.spec.containers[0].env", docs[0]
         )
 
+     def test_should_add_component_specific_labels(self):
+        docs = render_chart(
+            values={
+                "flower": {
+                    "enabled": True,
+                    "labels": {"test_label": "test_label_value"},
+                },
+            },
+            show_only=["templates/flower/flower-deployment.yaml"],

Review Comment:
   You need to check all of the flower templates.



##########
chart/values.yaml:
##########
@@ -586,6 +586,9 @@ workers:
 
   podAnnotations: {}
 
+  # Labels specific to workers

Review Comment:
   ```suggestion
     # Labels specific to workers objects and pods
   ```
   
   Should be like this across the board, also in the schema description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org