You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/08/01 11:21:24 UTC

[GitHub] asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information

asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841318
 
 

 ##########
 File path: server/metric/common.go
 ##########
 @@ -16,17 +16,44 @@
  */
 package metric
 
-import "time"
+import (
+	"github.com/astaxie/beego"
+	"net"
+	"sync"
+	"time"
+)
 
 const (
-	defaultMetricsSize = 100
-	collectInterval    = 5 * time.Second
+	collectInterval  = 5 * time.Second
 
 Review comment:
   Suggestion :  Can we make this interval time configurable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services