You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2007/02/01 21:05:05 UTC
[jira] Created: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
change XmlUpdateRequestHandler to use StAX instead of XPP
---------------------------------------------------------
Key: SOLR-133
URL: https://issues.apache.org/jira/browse/SOLR-133
Project: Solr
Issue Type: Improvement
Reporter: Hoss Man
there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
Thorsten - this looks good. I cleaned it up a bit and modified it to use SOLR-139. The big changes I made are:
* It uses two spaces (not tabs or 4 spaces)
* It overwrites the existing XmlUpdateRequestHandler rather then adding a parallel one. (We should either use StAX or XPP, but not both)
* It breaks out the xml parsing so that parsing a single document is an easily testable chunk:
SolrDocument readDoc(XMLStreamReader parser)
* It adds a test to make sure it reads documents correctly
* Since it is *the* XmlUpdateRequestHandler all the other tests that insert documents use it.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley reassigned SOLR-133:
----------------------------------
Assignee: Ryan McKinley
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Assignee: Ryan McKinley
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Scherler updated SOLR-133:
-----------------------------------
Attachment: SOLR-133.diff
Refactoring the XmlUpdateRequestHandler to use constant variables that can be reused by the Stax implementation. Adding a stax implementation for the XmlUpdateRequestHandler. Till now I get an error about missing content stream.
NOTE:
To make the version compile you need to download the JSR 173 API from
http://www.ibiblio.org/maven2/stax/stax-api/1.0/stax-api-1.0.jar
and copy it to $SOLR_HOME/lib/.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474337 ]
Hoss Man commented on SOLR-133:
-------------------------------
haven't reviewed any patches, but to address some of J.J.s earlier points: i assume the goal would be to move to STaX because it is reportadly as fast as XPP but is also the new standard for "fast" stream based processing.
As for replacing other XML parsing code in the solr code base -- XML parsing can probably be divided into two lumps:
1) processing input streams for updates (or more generally: "requests with ContentStreams" based on some of Ryan's recent patches)
2) config file parsing
while STaX sounds like it makes a lot of sense for #1, sticking with DOM parsing for #2 seems like a good idea ... using XPath to access arbitrary sections of config information is extremely handy and the performance issues with initialization from the config DOM doens't seem like a big issue.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-133.
--------------------------------
Resolution: Fixed
phew! The changelog frenzy was successful. Thank you eclipse.
The moved files have their revision history:
http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/common/params/SolrParams.java?view=log
and stub classs are all in place.
Since we have moved these files to a new location, I think we should try to clean up the depricated classes like CommonParams. There are essentially two types of "Param" classes
1. public static final String PARAM_NAME lists...
2. SolrParams helpers
but we should work on that later...
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469971 ]
Thorsten Scherler commented on SOLR-133:
----------------------------------------
It seems the diff does not show the other libs you need to compile.
You can download them from:
https://svn.apache.org/repos/asf/forrest/trunk/whiteboard/dispatcher/lib/
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470001 ]
Thorsten Scherler commented on SOLR-133:
----------------------------------------
@Larrea
1) standards-based
2) agree
3) agree
4) agree
StAX is become a standard. Not as fast as SAX but nearly. IMO the StAX implementation is as easy to follow as the xpp, personally I think even easier.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494005 ]
Thorsten Scherler commented on SOLR-133:
----------------------------------------
What is missing with this issue, where can I give a helping had.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494559 ]
Ryan McKinley commented on SOLR-133:
------------------------------------
>From Yonik on SOLR-231
>> Solr should assume UTF-8 encoding unless the contentType says otherwise.
>
> In general yes (when Solr is asked for a Reader).
> For XML, we should probably give the parser an InputStream.
> http://www.nabble.com/double-curl-calls-in-post.sh--tf2287469.html#a6369448
>
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494059 ]
Ryan McKinley commented on SOLR-133:
------------------------------------
If you have SOLR-193 + SOLR-139, i think most things are good...
We could easily remove the SOLR-139 dependency.
I think after solr1.2 (assuming it is sometime soon), this and SOLR-193 would be good to include.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley reopened SOLR-133:
--------------------------------
dooh -- wrong issue
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-133.
--------------------------------
Resolution: Fixed
this is the default implementation since r552198
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Assignee: Ryan McKinley
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to
use StAX instead of XPP
Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Sat, 2007-02-03 at 13:57 -0800, Thorsten Scherler (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Thorsten Scherler updated SOLR-133:
> -----------------------------------
>
> Attachment: SOLR-133.diff
>
> Fixing bugs from first version.
>
> Adding workaround for problem with direct use of the handler (never gets a stream).
> http://www.mail-archive.com/solr-dev@lucene.apache.org/msg02759.html
> by patching the SolrUpdateServlet
>
> Please test, it works fine for me.
This version does not change XmlUpdateRequestHandler to use StAX instead
of XPP, but adds a XmlUpdateRequestHandlerStax.
Since I need to touch the patch again to revert the SolrUpdateServlet, I
wonder whether we want both?
Should I prepare the next one to use StAX instead of XPP?
salu2
>
> > change XmlUpdateRequestHandler to use StAX instead of XPP
> > ---------------------------------------------------------
> >
> > Key: SOLR-133
> > URL: https://issues.apache.org/jira/browse/SOLR-133
> > Project: Solr
> > Issue Type: Improvement
> > Reporter: Hoss Man
> > Attachments: SOLR-133.diff, SOLR-133.diff
> >
> >
> > there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
>
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java & XML consulting, training and solutions
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Scherler updated SOLR-133:
-----------------------------------
Attachment: SOLR-133.diff
Fixing bugs from first version.
Adding workaround for problem with direct use of the handler (never gets a stream).
http://www.mail-archive.com/solr-dev@lucene.apache.org/msg02759.html
by patching the SolrUpdateServlet
Please test, it works fine for me.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "J.J. Larrea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469603 ]
J.J. Larrea commented on SOLR-133:
----------------------------------
It would be useful if there first were some consensus as to what the goals are for making a change to the XML Update Handler; some possibilities I can think of include:
1) To use standards-based rather than non-standards-based technologies as much as possible
2) To use as few different XML technologies (and coding styles related to the technology) as possible
3) To reduce as much as possible the complexity of code needed for interpreting XML command and/or configuration streams
4) To lower resource consumption and limitations for XML handling, e.g. stream-based rather than random-access
By all means add to that list, prioritize, and remove goals which are not seen as important.
Then it seems to me the question would be how many of those goals are addressed by changing XML Update Handler to stAX, vs. other technologies. One might at the same time also want to look at other places where SOLR decodes XML such as config files, to see if there can be more commonality rather than continued isolation.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
Applies cleaner with trunk - it still depends on SOLR-193 and SOLR-139, so "clean" may not be the best description.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
updated to work with most recent SOLR-139
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
applies (almost cleanly) with trunk + SOLR-193 + SOLR-139
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
fixed the document parser to handle fields with CDATA.
switch (event) {
// Add everything to the text
case XMLStreamConstants.SPACE:
case XMLStreamConstants.CDATA:
case XMLStreamConstants.CHARACTERS:
text.append( parser.getText() );
break;
...
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
Extracts the request parsing and update handling into two parts.
This adds an "UpdateRequestProcessor" that handles the actual updating. This offers a good place for authentication / document transformation etc. This can all be reuse if we have a JSONUpdate handler. The UpdateRequestProcessor can be changed using an init param in solrconfig,xml:
<requestHandler name="/update" class="solr.XmlUpdateRequestHandler" >
<str name="update.processor.class">org.apache.solr.handler.UpdateRequestProcessor</str>
</requestHandler>
Moved the XPP version to XppUpdateRequestHandler and mapped it to:
<requestHandler name="/update/xpp" class="solr.XppUpdateRequestHandler" />
My initial (not accurate) tests don't show any significant time difference between the two -- we should keep both in the code until we are confident the new one is stable.
- - - - -
Thorsten - can you check if the STAX includes are all in good shape? Is it ok to use:
import javanet.staxutils.BaseXMLInputFactory;
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
Updated to apply against trunk and removed the SOLR-139 dependency.
Not it just relies on SOLR-193.
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Comment: was deleted
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use
StAX instead of XPP
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-133:
-------------------------------
Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch
updated to apply with trunk + SOLR-262
Changed it to sit next to XmlUpdateRequestHandler -- this way it can be evaluated next to XmlUpdateRequestHandler rather then replace it.
The UpdateRequestProcessor interface needs review, but I think it can be done CTR...
> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
> Key: SOLR-133
> URL: https://issues.apache.org/jira/browse/SOLR-133
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of XPP ... opening an issue to track it as a possible improvement (orriginally mentioned in SOLR-61, but that task was more specificly about refactoring the existing code)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.