[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6680: [HUDI-4812] Lazy fetching partition path & file slice for HoodieFileIndex

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #6680:
URL: https://github.com/apache/hudi/pull/6680#discussion_r1007526943


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/PartitionPathFormatterBase.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.keygen;
+
+import org.apache.spark.unsafe.types.UTF8String;
+
+import java.util.List;
+import java.util.function.Supplier;
+
+import static org.apache.hudi.common.util.ValidationUtils.checkState;
+import static org.apache.hudi.keygen.KeyGenUtils.DEFAULT_PARTITION_PATH_SEPARATOR;
+
+/**
+ * Partition path formatter allows to efficiently combine partition paths into
+ * generic Java {@link String} (as well as engine-specific containers like
+ * {@code UTF8String} for ex), while being flexible in terms of
+ *
+ * <ul>
+ *   <li>Allowing to configure how to handle empty values</li>
+ *   <li>Allowing to encode individual values</li>
+ *   <li>Supporting Hive-style partitioning ({@code column=value})</li>
+ * </ul>
+ *
+ * @param <S> string type
+ */
+public abstract class PartitionPathFormatterBase<S> {

Review Comment:
   These partition-path formatter were extracted from `BuilinKeyGenerator` to be reused subsequently for partition-path composition in `SparkHoodieFileIndex`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org