[GitHub] [beam] tonytanger commented on a diff in pull request #25364: Create metadata table in initialize stage if table doesn't exist.

["tonytanger (via GitHub)" <gi...@apache.org>]

tonytanger commented on code in PR #25364:
URL: https://github.com/apache/beam/pull/25364#discussion_r1100685551


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java:
##########
@@ -124,9 +130,7 @@ public void testGcpApiSurface() throws Exception {
             classesInPackage("org.apache.commons.logging"),
             classesInPackage("org.codehaus.jackson"),
             classesInPackage("org.joda.time"),
-            Matchers.<Class<?>>equalTo(org.threeten.bp.Duration.class),
-            Matchers.<Class<?>>equalTo(org.threeten.bp.format.ResolverStyle.class),
-            classesInPackage("org.threeten.bp.temporal"),

Review Comment:
   I add the entire `org.threeten.bp` which covers these more specific matchers. The bigtable data client uses many of the classes in `org.threeten.bp`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org