You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/03 22:15:34 UTC

[GitHub] codecov-io commented on issue #4742: [sql lab] preserve schema through visualize flow

codecov-io commented on issue #4742: [sql lab] preserve schema through visualize flow
URL: https://github.com/apache/incubator-superset/pull/4742#issuecomment-378416836
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=h1) Report
   > Merging [#4742](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.2%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4742/graphs/tree.svg?height=150&src=pr&token=KsB0fHcx6l&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #4742     +/-   ##
   =========================================
   + Coverage   72.38%   72.58%   +0.2%     
   =========================================
     Files         205      205             
     Lines       15374    15376      +2     
     Branches     1182     1183      +1     
   =========================================
   + Hits        11128    11161     +33     
   + Misses       4243     4212     -31     
     Partials        3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...sets/javascripts/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `69.15% <ø> (ø)` | :arrow_up: |
   | [...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==) | `99.24% <100%> (ø)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.48% <100%> (+2.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=footer). Last update [f6fe11f...f86208e](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services