You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/15 21:12:40 UTC
[GitHub] [spark] c21 opened a new pull request #31845: [MINOR][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
c21 opened a new pull request #31845:
URL: https://github.com/apache/spark/pull/31845
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup minor change from https://github.com/apache/spark/pull/31821#discussion_r594110622 , where we change from using `execute()` to `executeTake()`. Performance-wise there's no difference. We are just using a different API to be aligned with code path of `Dataset`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To align with other code paths in SQL/Dataset.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing unit tests same as https://github.com/apache/spark/pull/31821 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799839881
Closed & reopened PR to trigger unit test in github action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799780925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799778052
Hi, @c21 . `[MINOR]` is used when we have no corresponding JIRA id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799780925
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31845:
URL: https://github.com/apache/spark/pull/31845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799903573
Thank you @dongjoon-hyun and @maropu for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799839382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136084/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799839980
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40667/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799779932
@dongjoon-hyun - thanks for correction. I was wrongly assuming followup PRs should not use original JIRA id. Will follow the convention next time, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 closed pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 closed pull request #31845:
URL: https://github.com/apache/spark/pull/31845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799902173
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799802572
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40665/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31845: [MINOR][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799755911
cc @cloud-fan and @maropu could you help take a look when you have time, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799839980
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40667/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799830385
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31845: [SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31845:
URL: https://github.com/apache/spark/pull/31845#issuecomment-799780660
BTW, GitHub Action is currently broken.
- https://www.githubstatus.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org