You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lo...@apache.org on 2023/06/07 18:52:54 UTC

[beam] branch master updated: Pass reference instead of value to cmp.Diff (#27053)

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 639dcf70b27 Pass reference instead of value to cmp.Diff (#27053)
639dcf70b27 is described below

commit 639dcf70b27b667cca0816a0d35ef7fb992f758c
Author: Jack McCluskey <34...@users.noreply.github.com>
AuthorDate: Wed Jun 7 14:52:46 2023 -0400

    Pass reference instead of value to cmp.Diff (#27053)
---
 sdks/go/pkg/beam/runners/prism/internal/jobservices/management_test.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdks/go/pkg/beam/runners/prism/internal/jobservices/management_test.go b/sdks/go/pkg/beam/runners/prism/internal/jobservices/management_test.go
index 7a87fed654e..b7861276702 100644
--- a/sdks/go/pkg/beam/runners/prism/internal/jobservices/management_test.go
+++ b/sdks/go/pkg/beam/runners/prism/internal/jobservices/management_test.go
@@ -114,7 +114,7 @@ func TestServer(t *testing.T) {
 				if err != nil {
 					t.Errorf("GetPipeline(\"job-001\") = %v, want nil", err)
 				}
-				if diff := cmp.Diff(jobpb.GetJobMetricsResponse{
+				if diff := cmp.Diff(&jobpb.GetJobMetricsResponse{
 					Metrics: &jobpb.MetricResults{
 						Committed: []*pipepb.MonitoringInfo{
 							{