[GitHub] [tinkerpop] aboudreault opened pull request #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["aboudreault (GitHub)" <gi...@apache.org>]

If there is additional documentation you would like somewhere... please, point me where.  

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["spmallette (GitHub)" <gi...@apache.org>]

I think this one is ok at this point - note the creation of https://issues.apache.org/jira/browse/TINKERPOP-2082 for other GLVs 

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["spmallette (GitHub)" <gi...@apache.org>]

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] aboudreault commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["aboudreault (GitHub)" <gi...@apache.org>]

@spmallette I addressed comments and fixed the initial issue we were seeing in travis. However, I am not able to reproduce this one: https://travis-ci.org/apache/tinkerpop/jobs/445261231#L7397 , everything seems to pass locally. Any pointer?

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["spmallette (GitHub)" <gi...@apache.org>]

I think there needs to be a documentation update too - i just noticed this:

http://tinkerpop.apache.org/docs/3.3.4/reference/#_limitations

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] aboudreault commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["aboudreault (GitHub)" <gi...@apache.org>]

@spmallette Let me look at how this scenario stuff works. I will add one that return a list.

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["spmallette (GitHub)" <gi...@apache.org>]

I re-ran the travis build and the error is gone. probably a fluke of travis or something. I guess this is good now.  do you happen to know if there is a test for the alternative scenario somewhere (i.e. where a set becomes a list)?

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

["spmallette (GitHub)" <gi...@apache.org>]

Thanks for submitting this....Travis seems unhappy on the gremlin-python version of the build....could you please have a look at that? Also, this looks like it needs a rebase now that we have the tp33 branch re-opened for development. That should get CHANGELOG setup for new entries. Please don't include the JIRA issue there - just a bullet point with your representation of what changed will suffice. 

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org