[GitHub] spark pull request #20832: [SPARK-20536][SQL] Extend ColumnName to create St...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20832#discussion_r223164144
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
    @@ -1208,85 +1208,172 @@ class ColumnName(name: String) extends Column(name) {
        */
       def boolean: StructField = StructField(name, BooleanType)
     
    +  /**
    +   * Creates a new `StructField` of type boolean.
    +   * @since 2.4.0
    +   */
    +  def boolean(nullable: Boolean): StructField = StructField(name, BooleanType, nullable)
    --- End diff --
    
    The NULL hints are not enforced. Thus, it is kind of risky to expose this to end users since it could generate a wrong result. We plan to ignore the user-specified NULL hints in the upcoming release. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org