You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/08/17 22:15:10 UTC
Review Request 37548: Hosts Page Performance: Hosts mapper running
time degrade over time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37548/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-12794
https://issues.apache.org/jira/browse/AMBARI-12794
Repository: ambari
Description
-------
Replacing foreach with for to reduce stack frame cost.
Diffs
-----
ambari-web/app/mappers/hosts_mapper.js 69f0139
Diff: https://reviews.apache.org/r/37548/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
6506 tests complete (9 seconds)
94 tests pending
Thanks,
Richard Zang
Re: Review Request 37548: Hosts Page Performance: Hosts mapper
running time degrade over time
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37548/#review95756
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Aug. 18, 2015, 6:30 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37548/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:30 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-12794
> https://issues.apache.org/jira/browse/AMBARI-12794
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replacing foreach with for to reduce stack frame cost.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/hosts_mapper.js 69f0139
>
> Diff: https://reviews.apache.org/r/37548/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 6506 tests complete (9 seconds)
> 94 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 37548: Hosts Page Performance: Hosts mapper
running time degrade over time
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37548/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:30 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Changes
-------
Add some comment.
Bugs: AMBARI-12794
https://issues.apache.org/jira/browse/AMBARI-12794
Repository: ambari
Description
-------
Replacing foreach with for to reduce stack frame cost.
Diffs (updated)
-----
ambari-web/app/mappers/hosts_mapper.js 69f0139
Diff: https://reviews.apache.org/r/37548/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
6506 tests complete (9 seconds)
94 tests pending
Thanks,
Richard Zang