You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/18 06:25:31 UTC
Review Request 43707: Windows:[1/3] Added zlib definitions for
Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704
Repository: mesos
Description
-------
This review was originally at #40567, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.
Diffs
-----
3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4
cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
Diff: https://reviews.apache.org/r/43707/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43707: Windows:[1/3] Added zlib definitions for
Windows.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/#review122993
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43707/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:25 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This review was originally at #40567, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4
> cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
>
> Diff: https://reviews.apache.org/r/43707/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43707: Windows:[1/3] Added zlib definitions for
Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/#review123088
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43707/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:25 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This review was originally at #40567, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4
> cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
>
> Diff: https://reviews.apache.org/r/43707/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>