You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/17 12:25:54 UTC
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4804:
Move MySQL binlog JSON type data logic to database/protocol module
codecov-io commented on issue #4804: Move MySQL binlog JSON type data logic to database/protocol module
URL: https://github.com/apache/incubator-shardingsphere/pull/4804#issuecomment-600042571
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=h1) Report
> Merging [#4804](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/cb2c4942c89a4cf09cd866f972f067a031fa6243&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `95.38%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4804 +/- ##
============================================
+ Coverage 56.32% 56.36% +0.03%
- Complexity 448 449 +1
============================================
Files 1164 1165 +1
Lines 20950 20972 +22
Branches 3883 3891 +8
============================================
+ Hits 11800 11820 +20
- Misses 8422 8424 +2
Partials 728 728
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/mysql/binlog/packet/binlog/RowsEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvUm93c0V2ZW50UGFja2V0LmphdmE=) | `73.68% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...row/column/value/string/MySQLJsonValueDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxKc29uVmFsdWVEZWNvZGVyLmphdmE=) | `87.28% <96.22%> (ø)` | `0.00 <0.00> (?)` | |
| [...abase/protocol/mysql/constant/MySQLColumnType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ29sdW1uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../column/value/MySQLBinlogProtocolValueFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9NeVNRTEJpbmxvZ1Byb3RvY29sVmFsdWVGYWN0b3J5LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...olumn/value/blob/MySQLBlobBinlogProtocolValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9ibG9iL015U1FMQmxvYkJpbmxvZ1Byb3RvY29sVmFsdWUuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...umn/value/string/MySQLJsonBinlogProtocolValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxKc29uQmlubG9nUHJvdG9jb2xWYWx1ZS5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rdingsphere/underlying/common/util/StringUtil.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `55.55% <0.00%> (-44.45%)` | `0.00% <0.00%> (ø%)` | |
| [...ying/common/properties/common/TypedProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3Byb3BlcnRpZXMvY29tbW9uL1R5cGVkUHJvcGVydGllcy5qYXZh) | `90.24% <0.00%> (+6.03%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=footer). Last update [cb2c494...61f76db](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4804?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services