[jira] [Commented] (HBASE-29659) Replace reflow-default-webdeps to fix site build failure

["Dávid Paksy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-29659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030255#comment-18030255 ] 

Dávid Paksy commented on HBASE-29659:
-------------------------------------

Many thanks [~ndimiduk] and [~zhangduo] for your reviews! (y)
Merged the change to master.

> Replace reflow-default-webdeps to fix site build failure
> --------------------------------------------------------
>
>                 Key: HBASE-29659
>                 URL: https://issues.apache.org/jira/browse/HBASE-29659
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Dávid Paksy
>            Assignee: Dávid Paksy
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: highlightjs-dependency-information-page.png
>
>
> When the nightly build builds the site, it fails with "patch has 1 errors when building the reference guide.":
> [https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1356/artifact/output-general/patch-refguide.log]
> The log contains this error:
> {noformat}
> [INFO] --- dependency:3.1.1:unpack (unpack-site-resources) @ hbase ---
> [INFO] Configured Artifact: io.github.devacfr.maven.skins:reflow-default-webdeps:2.3.3:jar
> [WARNING] The POM for io.github.devacfr.maven.skins:reflow-default-webdeps:jar:2.3.3 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building the effective model for io.github.devacfr.maven.skins:reflow-default-webdeps:2.3.3
> [ERROR] 'dependencies.dependency.systemPath' for io.github.devacfr:highlightjs:jar must specify an absolute path but is ${project.basedir}/src/main/resources/highlight.js-9.15.7.jar @ 
> {noformat}
> Even though there is the error above, the build log says success:
> {noformat}
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  05:35 min
> [INFO] Finished at: 2025-10-13T09:41:00+02:00
> [INFO] ------------------------------------------------------------------------
> {noformat}
> The build is successful, but I guess yetus will scan the output to see if there is an {{[ERROR]}}
> *I also checked the locally generated site and the RefGuide (book.html) and they are fine.*
> Under https://issues.apache.org/jira/browse/HBASE-29152 we replaced the Maven website skin to the Reflow2 Maven skin ([https://devacfr.github.io/reflow-maven-skin/]). Maven complains about the io.github.devacfr.maven.skins:reflow-default-webdeps:jar:2.3.3 which is required for our new site skin to use local resources (CSS, JS, etc). We need to use local resources because the Content Security Policy does not allow to load these CSS, JS from remote sites (from CDN).
> This reflow-default-webdeps jar contains these resources. It's pom contains this highlightjs system dependency.
> {noformat}
> ...
>   <dependencies>
>     <dependency>
>       <groupId>io.github.devacfr</groupId>
>       <artifactId>highlightjs</artifactId>
>       <version>${highlightJsVersion}</version>
>       <type>jar</type>
>       <scope>system</scope>
>       <systemPath>${project.basedir}/src/main/resources/highlight.js-${highlightJsVersion}.jar</systemPath>
>       <optional>true</optional>
>     </dependency>
>   </dependencies>
> ...{noformat}
> [https://repo1.maven.org/maven2/io/github/devacfr/maven/skins/reflow-default-webdeps/2.3.3/reflow-default-webdeps-2.3.3.pom]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)