You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/01 14:53:55 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6515: Minor: Clean up `use`s to point at real crates

alamb opened a new pull request, #6515:
URL: https://github.com/apache/arrow-datafusion/pull/6515

   # Which issue does this PR close?
   
   This is part of https://github.com/apache/arrow-datafusion/issues/1754
   
   # Rationale for this change
   
   I want to decouple physical_plan from the core datafusion library -- I have already removed most of the actual dependencies, but there are still some dependencies that look real (because they do `use crate::execution:...` ) but are actual using a re-export. 
   
   # What changes are included in this PR?
   
   This updates the `use` statements in `physical_plan` to not use the backward compatible aliases but the actual new locations
   # Are these changes tested?
   covered by existing tests
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   No
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6515: Minor: Clean up `use`s to point at real crates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6515:
URL: https://github.com/apache/arrow-datafusion/pull/6515#discussion_r1213285608


##########
datafusion/core/src/physical_plan/aggregates/bounded_aggregate_stream.rs:
##########
@@ -31,9 +31,9 @@ use futures::stream::{Stream, StreamExt};
 use hashbrown::raw::RawTable;
 use itertools::izip;
 
-use crate::execution::context::TaskContext;
-use crate::execution::memory_pool::proxy::{RawTableAllocExt, VecAllocExt};
-use crate::execution::memory_pool::{MemoryConsumer, MemoryReservation};
+use datafusion_execution::TaskContext;

Review Comment:
   this is the core of the change -- use the actual dependencies rather than backward compatible pub use's 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6515: Minor: Clean up `use`s to point at real crates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6515:
URL: https://github.com/apache/arrow-datafusion/pull/6515#discussion_r1213287202


##########
datafusion/execution/src/lib.rs:
##########
@@ -25,4 +25,6 @@ pub mod registry;
 pub mod runtime_env;
 mod task;
 
+pub use disk_manager::DiskManager;

Review Comment:
   moved from the backwards compatibility crates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6515: Minor: Clean up `use`s to point at real crates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6515:
URL: https://github.com/apache/arrow-datafusion/pull/6515#issuecomment-1573954755

   This one I think is non controversial so merging it in now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6515: Minor: Clean up `use`s to point at real crates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6515:
URL: https://github.com/apache/arrow-datafusion/pull/6515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org