You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/05/03 19:06:26 UTC

Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2521
    https://issues.apache.org/jira/browse/ATLAS-2521


Repository: atlas


Description
-------

Now that Atlas is using JanusGraph as the backend store and all new features developed depends on TinkerPop3 queries and enhanced capabilities of JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.


Diffs
-----

  addons/falcon-bridge-shim/pom.xml e2c41b3a 
  addons/falcon-bridge/pom.xml 53f6d368 
  addons/falcon-bridge/src/test/resources/atlas-application.properties 91fd8b09 
  addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
  addons/hbase-bridge/src/test/resources/atlas-application.properties 91fd8b09 
  addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
  addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
  addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
  addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
  addons/sqoop-bridge/src/test/resources/atlas-application.properties 91fd8b09 
  addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
  addons/storm-bridge/src/test/resources/atlas-application.properties 5e3836ba 
  addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
  authorization/src/test/resources/atlas-application.properties 2e02678a 
  build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
  common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
  common/src/test/resources/atlas-log4j.xml 8a1de629 
  distro/pom.xml 9f6f2bdc 
  distro/src/conf/atlas-env.sh 9213f488 
  distro/src/conf/atlas-log4j.xml a0f96296 
  distro/src/conf/solr/schema.xml 1d445b15 
  distro/src/conf/solr/solrconfig.xml 1d414f76 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java d6806541 
  graphdb/janus/readme.txt fb935be2 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 86cd2990 
  graphdb/pom.xml cef77c94 
  graphdb/readme.txt 92edd002 
  graphdb/titan0/pom.xml dc840581 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java e255f1b6 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java feb578bd 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java 0cd47950 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java 7e8f72d1 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c1af7b66 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java 2c0f3b4b 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java bb3fb3b0 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java e5c3d31c 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 4d61b608 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java d454f379 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java 4bdd3204 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java e13593fa 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java 86606447 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java 91e50266 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java b11532ac 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java 5c90617c 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java 54f87434 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 95669af3 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 90d24e4d 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/database/idassigner/StandardIDPool.java 6c7a0863 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java 3a466c0b 
  graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 8e0928c8 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java 73097f25 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java 1d5d4090 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0EdgeLabel.java 934e255a 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java 3b506331 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java d191b554 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java 5af90d8c 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 3d4152e9 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java fadd5965 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java c4a312d8 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0PropertyKey.java d6707bd8 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java e439ab96 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 39e9d6d7 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java b7c25b87 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 68a7048b 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0GraphQuery.java 234e5212 
  graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java 21087a5d 
  graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java b3cf4f71 
  graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java 513813db 
  graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java 5e022052 
  graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e255e6c2 
  graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java b70d3221 
  graphdb/titan0/src/test/resources/atlas-application.properties 61888731 
  intg/src/main/resources/atlas-log4j.xml 510e2cfe 
  intg/src/test/resources/atlas-application.properties af9c3d72 
  pom.xml aa675cc9 
  repository/pom.xml 4c39b282 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java f5174450 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 40154d98 
  tools/atlas-migration-exporter/pom.xml 71a529fb 
  tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java 2af8b7d9 
  tools/atlas-migration-exporter/src/main/resources/atlas-log4j.xml ae0d27de 
  webapp/pom.xml 284f538f 
  webapp/src/test/resources/atlas-application.properties 275ac338 


Diff: https://reviews.apache.org/r/66936/diff/1/


Testing
-------

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/341/console


Thanks,

Sarath Subramanian


Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202381
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 3, 2018, 7:06 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 7:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
>     https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Now that Atlas is using JanusGraph as the backend store and all new features developed depends on TinkerPop3 queries and enhanced capabilities of JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java e255f1b6 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java feb578bd 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java 0cd47950 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java 7e8f72d1 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c1af7b66 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java 2c0f3b4b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java bb3fb3b0 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java e5c3d31c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 4d61b608 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java d454f379 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java 4bdd3204 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java e13593fa 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java 86606447 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java 91e50266 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java b11532ac 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java 5c90617c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java 54f87434 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 95669af3 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 90d24e4d 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/database/idassigner/StandardIDPool.java 6c7a0863 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java 3a466c0b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 8e0928c8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java 73097f25 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java 1d5d4090 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0EdgeLabel.java 934e255a 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java 3b506331 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java d191b554 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java 5af90d8c 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 3d4152e9 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java fadd5965 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java c4a312d8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0PropertyKey.java d6707bd8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java e439ab96 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 39e9d6d7 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java b7c25b87 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 68a7048b 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0GraphQuery.java 234e5212 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java 21087a5d 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java b3cf4f71 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java 513813db 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java 5e022052 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e255e6c2 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java b70d3221 
>   graphdb/titan0/src/test/resources/atlas-application.properties 61888731 
>   intg/src/main/resources/atlas-log4j.xml 510e2cfe 
>   intg/src/test/resources/atlas-application.properties af9c3d72 
>   pom.xml aa675cc9 
>   repository/pom.xml 4c39b282 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java f5174450 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 40154d98 
>   tools/atlas-migration-exporter/pom.xml 71a529fb 
>   tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java 2af8b7d9 
>   webapp/pom.xml 284f538f 
>   webapp/src/test/resources/atlas-application.properties 275ac338 
> 
> 
> Diff: https://reviews.apache.org/r/66936/diff/2/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/341/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

Posted by Sarath Subramanian <sa...@apache.org>.

> On May 3, 2018, 1:01 p.m., Madhan Neethiraj wrote:
> > tools/atlas-migration-exporter/pom.xml
> > Line 37 (original)
> > <https://reviews.apache.org/r/66936/diff/1/?file=2016502#file2016502line37>
> >
> >     migration-exporter needs to read data in previous Atlas release, which uses titan-0.5.4. So, I think almost all changes to atlas-migration-exporter module need to be reverted.
> >     
> >     Please make sure that references to Titan are restricted to atlas-migration-exporter module.

there is a reference to atlas-titan0-graphdb in the pom.xml of atlas-migration-exporter. I'm removing it now and Ashutosh will fix titan0 dependency in a follow up patch.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202371
-----------------------------------------------------------


On May 3, 2018, 12:06 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 12:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
>     https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Now that Atlas is using JanusGraph as the backend store and all new features developed depends on TinkerPop3 queries and enhanced capabilities of JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java e255f1b6 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java feb578bd 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java 0cd47950 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java 7e8f72d1 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c1af7b66 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java 2c0f3b4b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java bb3fb3b0 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java e5c3d31c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 4d61b608 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java d454f379 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java 4bdd3204 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java e13593fa 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java 86606447 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java 91e50266 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java b11532ac 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java 5c90617c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java 54f87434 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 95669af3 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 90d24e4d 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/database/idassigner/StandardIDPool.java 6c7a0863 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java 3a466c0b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 8e0928c8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java 73097f25 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java 1d5d4090 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0EdgeLabel.java 934e255a 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java 3b506331 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java d191b554 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java 5af90d8c 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 3d4152e9 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java fadd5965 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java c4a312d8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0PropertyKey.java d6707bd8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java e439ab96 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 39e9d6d7 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java b7c25b87 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 68a7048b 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0GraphQuery.java 234e5212 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java 21087a5d 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java b3cf4f71 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java 513813db 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java 5e022052 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e255e6c2 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java b70d3221 
>   graphdb/titan0/src/test/resources/atlas-application.properties 61888731 
>   intg/src/main/resources/atlas-log4j.xml 510e2cfe 
>   intg/src/test/resources/atlas-application.properties af9c3d72 
>   pom.xml aa675cc9 
>   repository/pom.xml 4c39b282 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java f5174450 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 40154d98 
>   tools/atlas-migration-exporter/pom.xml 71a529fb 
>   tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java 2af8b7d9 
>   webapp/pom.xml 284f538f 
>   webapp/src/test/resources/atlas-application.properties 275ac338 
> 
> 
> Diff: https://reviews.apache.org/r/66936/diff/2/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/341/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202371
-----------------------------------------------------------




tools/atlas-migration-exporter/pom.xml
Line 37 (original)
<https://reviews.apache.org/r/66936/#comment284190>

    migration-exporter needs to read data in previous Atlas release, which uses titan-0.5.4. So, I think almost all changes to atlas-migration-exporter module need to be reverted.
    
    Please make sure that references to Titan are restricted to atlas-migration-exporter module.


- Madhan Neethiraj


On May 3, 2018, 7:06 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 7:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
>     https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Now that Atlas is using JanusGraph as the backend store and all new features developed depends on TinkerPop3 queries and enhanced capabilities of JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java e255f1b6 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java feb578bd 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java 0cd47950 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java 7e8f72d1 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c1af7b66 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java 2c0f3b4b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java bb3fb3b0 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java e5c3d31c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 4d61b608 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java d454f379 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java 4bdd3204 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java e13593fa 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java 86606447 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java 91e50266 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java b11532ac 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java 5c90617c 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java 54f87434 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 95669af3 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 90d24e4d 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/database/idassigner/StandardIDPool.java 6c7a0863 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java 3a466c0b 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 8e0928c8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java 73097f25 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java 1d5d4090 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0EdgeLabel.java 934e255a 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java 3b506331 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java d191b554 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java 5af90d8c 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 3d4152e9 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java fadd5965 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java c4a312d8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0PropertyKey.java d6707bd8 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java e439ab96 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 39e9d6d7 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java b7c25b87 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 68a7048b 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0GraphQuery.java 234e5212 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java 21087a5d 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java b3cf4f71 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java 513813db 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java 5e022052 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e255e6c2 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java b70d3221 
>   graphdb/titan0/src/test/resources/atlas-application.properties 61888731 
>   intg/src/main/resources/atlas-log4j.xml 510e2cfe 
>   intg/src/test/resources/atlas-application.properties af9c3d72 
>   pom.xml aa675cc9 
>   repository/pom.xml 4c39b282 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java f5174450 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 40154d98 
>   tools/atlas-migration-exporter/pom.xml 71a529fb 
>   tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java 2af8b7d9 
>   tools/atlas-migration-exporter/src/main/resources/atlas-log4j.xml ae0d27de 
>   webapp/pom.xml 284f538f 
>   webapp/src/test/resources/atlas-application.properties 275ac338 
> 
> 
> Diff: https://reviews.apache.org/r/66936/diff/1/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/341/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>