[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3150: Support non-correlated subquery in having clause

[GitBox <gi...@apache.org>]

wutiangan commented on a change in pull request #3150: Support non-correlated subquery in having clause
URL: https://github.com/apache/incubator-doris/pull/3150#discussion_r397235776
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/Expr.java
 ##########
 @@ -1462,6 +1462,18 @@ public Subquery getSubquery() {
         return subqueries.get(0);
     }
 
+    public boolean isCorrelatedPredicate(List<TupleId> tupleIdList) {
+        if ((this instanceof BinaryPredicate || this instanceof SlotRef) && !this.isBoundByTupleIds(tupleIdList)) {
+            return true;
+        }
 
 Review comment:
   why you add “this instanceof BinaryPredicate ”？
   only slotref has override isBoundByTupleIds function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org