You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/01 18:04:12 UTC

[GitHub] [trafficserver] ywkaras commented on pull request #8867: Add utility for printing string_view with printf-like functions.

ywkaras commented on PR #8867:
URL: https://github.com/apache/trafficserver/pull/8867#issuecomment-1143967621

   > What do you think about using fmtlib? Seems like it supports string_view.
   > 
   > #7296
   
   Looks good except for one apparent, huge flaw, when you print to a buffer, you don't pass in the buffer length it seems:  https://github.com/bryancall/format-benchmark/commit/0fc372058e7db96de3423a989173a9bc0fe68533#diff-a7cd0eba35fcc2bae863d4093c81bac869812eb9017cbf152308481c80af9716R430
   
   So presumably that means you can corrupt memory potentially.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org