You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Nick Burch <ni...@alfresco.com> on 2010/06/11 23:06:31 UTC
[VOTE] Release POI 3.7 beta 1
Hi All
It's been about 6 months now since 3.6 FINAL, and the changelog [1] shows
we've fixed a fairly hefty number of bugs, even if there haven't been that
many new features. So, I'd like to propose that we do a beta release now.
The release candidate files are available from:
http://people.apache.org/~nick/POI-3.7-beta1/
(The standard packages of source and binary are under /dist/, while the
jars and poms to feed into the maven repo are in /maven/)
As with all apache release votes, please check that not only does the code
work, and no major breakages have occured since the last release, but also
that packaging is correct, license headers and notices exist etc.
For anyone running with the full ooxml-schemas jar (instead of the
cut-down poi-ooxml-schemas jar), please not that this beta requires
version 1.1, which is the same XSDs but compiled for Java 1.5. You can get
this by running the "compile-ooxml-xsds" ant task, or from Maven (Yegor
will be uploading it shortly)
Voting to bless the release candidates as the 3.7 beta 1 release will run
until Wednesday 16th June. Please vote:
+1 - I support this release
0 - I don't object to this release, but I haven't checked it
-1 - There's a problem with the release, and that is ....
Nick
[1] http://poi.apache.org/changes.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Cancelled] [VOTE] Release POI 3.7 beta 1
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 11 Jun 2010, Nick Burch wrote:
> The release candidate files are available from:
> http://people.apache.org/~nick/POI-3.7-beta1/
The 3.7-beta1-20100616 candidate vote has failed. A new vote for the
3.7-beta1-20100620 candidates will start shortly
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Nick Burch <ni...@alfresco.com>.
On Mon, 14 Jun 2010, Yegor Kozlov wrote:
> Perhaps XmlBeans 2.4 does a better job.
The problem is that if we go to 2.4, then everyone who uses poi has to,
and as I understand it lots of our users use 2.3, and will have a faff to
upgrade and re-test their production stacks. That's why I haven't pushed
an upgrade in the past
> (a) revert to ooxml-schemas-1.0.jar and re-cut release. I'm +1 in advance.
I'm keep to get a beta release out soon (I've a bunch of tika patches that
can't be applied until there's a new poi release for tika to switch to,
and I'm getting bored of maintaining my own tree+build...)
So, tomorrow I'll switch trunk back to ooxml-schemas-1.0.jar, cut a new
beta1 release, then re-apply the ooxml-schemas-1.1.jar bits. If all goes
well, we've then got a month to fix the remaining deprecation warnings and
make the code shorter+nicer
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Yegor Kozlov <ye...@dinom.ru>.
My opinion is that it is not correct to release with a new dependency
that brings 120+ deprecation warnings. At the same time, I'm very
reluctant to rewrite all getXXXArray() to getXXXList() just to keep
javac quiet. I wonder if it is possible to suppress them and build
ooxml-schemas-1.1.jar with JDK 1.5 support AND getXXXArray() being not
deprecated. Perhaps XmlBeans 2.4 does a better job.
The purpose of switching to ooxml-schemas-1.1.jar is to use shorter and
nicer code. Instead we just switch jars and get tons of warnings.
I see two paths to follow:
(a) revert to ooxml-schemas-1.0.jar and re-cut release. I'm +1 in advance.
(b) abort the vote, test-drive ooxml-schemas-1.1.jar for a month or so
and cut release in July.
Current combination of old code and new new jar does not work for me.
Yegor
On Mon, 14 Jun 2010, Yegor Kozlov wrote:
>> I propose to revert trunk and REL_3_7_BETA1 to use
>> ooxml-schemas-1.0.jar (JDK 1.4). There is only one or two classes
>> using JDK 1.5 features and it should be easy.
>> Then re-cut release and only after it change trunk to use
>> ooxml-schemas-1.1.jar. This way it will be safe.
>
> That would mean that we wouldn't get any feedback from the beta about
> how well the JDK 1.5 version (ooxml-schemas-1.1) performs though. It
> is a beta, so I'm personally happy to have something in there that
> ought to work but might break in odd situations (I've inadvertantly
> been testing the 1.1 jar for ages without issue, and I'm probably no
> the only one!)
>
> I'll also promise to RM another beta release in a month, or sooner if
> we discover a big snag! Is that likely to be enough for people, or is
> there a view that we should keep things very stable here, and
> potentially have the next beta be less stable?
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Nick Burch <ni...@alfresco.com>.
On Mon, 14 Jun 2010, Yegor Kozlov wrote:
> I propose to revert trunk and REL_3_7_BETA1 to use ooxml-schemas-1.0.jar
> (JDK 1.4). There is only one or two classes using JDK 1.5 features and it
> should be easy.
> Then re-cut release and only after it change trunk to use
> ooxml-schemas-1.1.jar. This way it will be safe.
That would mean that we wouldn't get any feedback from the beta about how
well the JDK 1.5 version (ooxml-schemas-1.1) performs though. It is a
beta, so I'm personally happy to have something in there that ought to
work but might break in odd situations (I've inadvertantly been testing
the 1.1 jar for ages without issue, and I'm probably no the only one!)
I'll also promise to RM another beta release in a month, or sooner if we
discover a big snag! Is that likely to be enough for people, or is there a
view that we should keep things very stable here, and potentially have the
next beta be less stable?
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Yegor Kozlov <ye...@dinom.ru>.
> The switch to compiling the ooxml schemas as Java 1.5 was made in late
> 2009 by yourself, or so svn blame tells me...
> ------------------------------------------------------------------------
> r882927 | yegor | 2009-11-21 15:30:54 +0000 (Sat, 21 Nov 2009) | 1 line
>
> included poi-ooxml-schemas and poi-examples in the release cycle, also
> misc improvements in build.xml: merged scratchpad and main examples,
> improved cross-module classpath dependencies, removed obsolete targets
> ------------------------------------------------------------------------
>
> Quite happy to go with whatever you think about the naming though,
> since it was your change! I've tweaked the docs slightly.
>
>
My bad. I forgot about this change and thought it was recently made by you.
>
>> Another point is the recent research performed by Bruce Alcock
>> (Bryce.Alcock@sungard.com) - improper calls of setXXXArray() can
>> significatnly affect performance. I made a number of improvements in
>> XSSFSheet and XSSFRow and would like to research performance of
>> setXXXList() vs setXXXArray()
>
> There's no such thing as setXXXList - it still seems to be
> setXXXArray. AFAICT, it's only the get methods which switch when you
> compile for Java 1.5, not the setters
>
The returned list is mutable and should support random insertions like
xmlobj.getXXXList().add(idx, bean). I wonder about the performance.
>
> I'm tempted to do a new set of beta 1 artifacts and restart the
> voting. Would that work for you?
>
I propose to revert trunk and REL_3_7_BETA1 to use
ooxml-schemas-1.0.jar (JDK 1.4). There is only one or two classes using
JDK 1.5 features and it should be easy.
Then re-cut release and only after it change trunk to use
ooxml-schemas-1.1.jar. This way it will be safe.
Yegor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Nick Burch <ni...@alfresco.com>.
On Mon, 14 Jun 2010, Yegor Kozlov wrote:
> (1) REL_3_7_BETA1 depends on ooxml-schemas-1.0.jar
> If I do clean checkout and then "ant dist" then the compilation fails,
> however if I run the compile-ooxml-xsds target first then the compilation
> complets OK.
Looks like a missing dependency on one of the ant tasks, should be fixed
in r954507.
> We should clearly distinguish: ooxml-schemas-1.0.jar is JDK 1.4 and
> ooxml-schemas-1.1.jar is JDK 1.5.
The switch to compiling the ooxml schemas as Java 1.5 was made in late
2009 by yourself, or so svn blame tells me...
------------------------------------------------------------------------
r882927 | yegor | 2009-11-21 15:30:54 +0000 (Sat, 21 Nov 2009) | 1 line
included poi-ooxml-schemas and poi-examples in the release cycle, also
misc improvements in build.xml: merged scratchpad and main examples,
improved cross-module classpath dependencies, removed obsolete targets
------------------------------------------------------------------------
Quite happy to go with whatever you think about the naming though, since
it was your change! I've tweaked the docs slightly.
> (2) build of REL_3_7_BETA1 is locale-sensitive. There are two unit tests
> that fail if the sources are compiled in the ASCII encoding. I confirmed
> the problem on Win7 and Solaris.
I'm surprised we didn't set the encoding before, but thanks for fixing it!
> (3) Compilation against ooxml-schemas-1.1.jar completes with 124 new
> deprecation warnings.
>
> Actually, all calls of kind xmlbean.getXXXArray() are deprecated in favor of
> xmlbean.getXXXList().
I've been seeing these warnings for months, but not thought much about
them. Anyone who has a svn checkout, who since late november has done an
"ant clean" will have been running on the Java 1.5 version of the schemas.
I think it would be good to clean up the warnings, but I don't see an
urgent need to do it before the beta, probably only before the final
> I'm fine with using ooxml-schemas-1.1.jar and JDK 1.5 syntax but we
> should adjust our codebase and test-drive it for at least one month
> before cutting release.
See above, I think quite a few of us have been trying it for a while
without realising!
> Another point is the recent research performed by Bruce Alcock
> (Bryce.Alcock@sungard.com) - improper calls of setXXXArray() can
> significatnly affect performance. I made a number of improvements in
> XSSFSheet and XSSFRow and would like to research performance of setXXXList()
> vs setXXXArray()
There's no such thing as setXXXList - it still seems to be setXXXArray.
AFAICT, it's only the get methods which switch when you compile for Java
1.5, not the setters
I'm tempted to do a new set of beta 1 artifacts and restart the voting.
Would that work for you?
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by David Fisher <df...@jmlafferty.com>.
The following bugzilla wtih CTComment is a case: https://issues.apache.org/bugzilla/show_bug.cgi?id=49432
> Actually, all calls of kind xmlbean.getXXXArray() are deprecated in favor of xmlbean.getXXXList().
> I'm fine with using ooxml-schemas-1.1.jar and JDK 1.5 syntax but we should adjust our codebase and test-drive it for at least one month before cutting release.
> Another point is the recent research performed by Bruce Alcock (Bryce.Alcock@sungard.com) - improper calls of setXXXArray() can significatnly affect performance. I made a number of improvements in XSSFSheet and XSSFRow and would like to research performance of setXXXList() vs setXXXArray() . Until I do it, I would rather abstain from switching to ooxml-schemas-1.1.jar.
Bruce has communicated with the XMLBeans project and they are not likely to make changes. Some of the code I have seen actually does insertion using the worst case of algorithm of going through every element in a LIST to add to the end. I suspect getXXXList to be this bad actor.
Regards,
Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Yegor Kozlov <ye...@dinom.ru>.
-1.
there are some last-minute changes that seem show stoppers.
(1) REL_3_7_BETA1 depends on ooxml-schemas-1.0.jar
If I do clean checkout and then "ant dist" then the compilation fails,
however if I run the compile-ooxml-xsds target first then the
compilation complets OK.
We should clearly distinguish: ooxml-schemas-1.0.jar is JDK 1.4 and
ooxml-schemas-1.1.jar is JDK 1.5.
(2) build of REL_3_7_BETA1 is locale-sensitive. There are two unit
tests that fail if the sources are compiled in the ASCII encoding. I
confirmed the problem on Win7 and Solaris.
The first failure is in
org.apache.poi.hssf.extractor.TestExcelExtractor#testFormatting():
assertTrue(
text.indexOf(
"£nn.nn\t£10.52\n"
) > -1
);
The second failue is
org.apache.poi.hssf.usermodel.TestHSSFDataFormatter#testFromFile()
// text isn't quite the format rule...
assertEquals("£nn.nn",
sheet.getRow(12).getCell(0).getStringCellValue());
assertEquals("\"£\"#,##0.00",
sheet.getRow(12).getCell(1).getCellStyle().getDataFormatString());
assertEquals("£10.52",
f.formatCellValue(sheet.getRow(12).getCell(1)));
The Pound sign isn't properly converted into byte code. The workaround
is to use unicode notation:
assertTrue(
text.indexOf(
"\u00a3nn.nn\t\u00a310.52\n"
) > -1
);
it always works.
I fixed the problem in r954172, but it was after REL_3_7_BETA1.
(3) Compilation against ooxml-schemas-1.1.jar completes with 124 new
deprecation warnings.
Actually, all calls of kind xmlbean.getXXXArray() are deprecated in
favor of xmlbean.getXXXList().
I'm fine with using ooxml-schemas-1.1.jar and JDK 1.5 syntax but we
should adjust our codebase and test-drive it for at least one month
before cutting release.
Another point is the recent research performed by Bruce Alcock
(Bryce.Alcock@sungard.com) - improper calls of setXXXArray() can
significatnly affect performance. I made a number of improvements in
XSSFSheet and XSSFRow and would like to research performance of
setXXXList() vs setXXXArray() . Until I do it, I would rather abstain
from switching to ooxml-schemas-1.1.jar.
Yegor
Hi All
>
> It's been about 6 months now since 3.6 FINAL, and the changelog [1]
> shows we've fixed a fairly hefty number of bugs, even if there haven't
> been that many new features. So, I'd like to propose that we do a beta
> release now.
>
> The release candidate files are available from:
> http://people.apache.org/~nick/POI-3.7-beta1/
> (The standard packages of source and binary are under /dist/, while
> the jars and poms to feed into the maven repo are in /maven/)
>
> As with all apache release votes, please check that not only does the
> code work, and no major breakages have occured since the last release,
> but also that packaging is correct, license headers and notices exist
> etc.
>
> For anyone running with the full ooxml-schemas jar (instead of the
> cut-down poi-ooxml-schemas jar), please not that this beta requires
> version 1.1, which is the same XSDs but compiled for Java 1.5. You can
> get this by running the "compile-ooxml-xsds" ant task, or from Maven
> (Yegor will be uploading it shortly)
>
>
> Voting to bless the release candidates as the 3.7 beta 1 release will
> run until Wednesday 16th June. Please vote:
>
> +1 - I support this release
> 0 - I don't object to this release, but I haven't checked it
> -1 - There's a problem with the release, and that is ....
>
> Nick
>
> [1] http://poi.apache.org/changes.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Yohan Yudanara <yo...@gmail.com>.
Ok, but I hope someday this bug will be fixed :)
I think this bug is a major one because one of the feature listed in
documentation is not working and method setPrintArea() now useless.
I'm trying to dig into the source code and comparing with poi-3.2, but
the differences is quite big and I'm having difficulty to solve this.
So, at this moment, I choose to fallback to poi-3.2 because I need
this feature.
Thanks anyway..
If I have more time, I will investigate further about this bug.
On Mon, Jun 14, 2010 at 4:51 PM, Nick Burch <ni...@alfresco.com> wrote:
> On Mon, 14 Jun 2010, Yohan Yudanara wrote:
>>
>> -1 - There's a problem with the release, and that is: "set print area"
>> is not working
>> (https://issues.apache.org/bugzilla/show_bug.cgi?id=46664)
>
> I'm not sure that this problem counts as serious enough to block a beta
> release, sorry.
>
> If it really matters to you, then you'll probably need to dig into the
> formula parser to work out why the print area references are being done
> differently now
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Nick Burch <ni...@alfresco.com>.
On Mon, 14 Jun 2010, Yohan Yudanara wrote:
> -1 - There's a problem with the release, and that is: "set print area"
> is not working
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=46664)
I'm not sure that this problem counts as serious enough to block a beta
release, sorry.
If it really matters to you, then you'll probably need to dig into the
formula parser to work out why the print area references are being done
differently now
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Release POI 3.7 beta 1
Posted by Yohan Yudanara <yo...@gmail.com>.
-1 - There's a problem with the release, and that is: "set print area"
is not working
(https://issues.apache.org/bugzilla/show_bug.cgi?id=46664)
This was happening since poi-3.5.
Print area is working on poi-3.2.
On Sat, Jun 12, 2010 at 4:06 AM, Nick Burch <ni...@alfresco.com> wrote:
> Hi All
>
> It's been about 6 months now since 3.6 FINAL, and the changelog [1] shows
> we've fixed a fairly hefty number of bugs, even if there haven't been that
> many new features. So, I'd like to propose that we do a beta release now.
>
> The release candidate files are available from:
> http://people.apache.org/~nick/POI-3.7-beta1/
> (The standard packages of source and binary are under /dist/, while the jars
> and poms to feed into the maven repo are in /maven/)
>
> As with all apache release votes, please check that not only does the code
> work, and no major breakages have occured since the last release, but also
> that packaging is correct, license headers and notices exist etc.
>
> For anyone running with the full ooxml-schemas jar (instead of the cut-down
> poi-ooxml-schemas jar), please not that this beta requires version 1.1,
> which is the same XSDs but compiled for Java 1.5. You can get this by
> running the "compile-ooxml-xsds" ant task, or from Maven (Yegor will be
> uploading it shortly)
>
>
> Voting to bless the release candidates as the 3.7 beta 1 release will run
> until Wednesday 16th June. Please vote:
>
> +1 - I support this release
> 0 - I don't object to this release, but I haven't checked it
> -1 - There's a problem with the release, and that is ....
>
> Nick
>
> [1] http://poi.apache.org/changes.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org