You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2018/10/30 07:42:42 UTC

[kylin] 02/02: KYLIN-3582 String compare should use equals method

This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch 2.5.x
in repository https://gitbox.apache.org/repos/asf/kylin.git

commit cf6d58b0d518deda28c3a9c3992106313c10acae
Author: hit-lacus <hi...@126.com>
AuthorDate: Mon Sep 24 23:18:54 2018 +0800

    KYLIN-3582 String compare should use equals method
---
 .../src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java b/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
index f5bc797..93da2f4 100644
--- a/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
+++ b/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
@@ -261,11 +261,10 @@ public class RecordEvent implements Record, Map<String, Object>, Serializable {
 
         public RecordReserveKeyEnum getByKey(String key) {
             for (RecordReserveKeyEnum reserveKey : RecordReserveKeyEnum.values()) {
-                if (reserveKey.reserveKey == key) {
+                if (reserveKey.reserveKey.equals(key)) {
                     return reserveKey;
                 }
             }
-
             return null;
         }
     }