You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/04/30 10:13:12 UTC
[GitHub] [httpcomponents-client] arturobernalg opened a new pull request, #441: Title: Introduce new LinearBackoffManager with cool-down period and route-specific attempts
arturobernalg opened a new pull request, #441:
URL: https://github.com/apache/httpcomponents-client/pull/441
This pull request introduces a new `LinearBackoffManager` class, providing a more efficient and robust connection pool management strategy using cool-down periods and route-specific backoff/probe attempts.
Main features:
1. Add ConcurrentHashMaps to store lastRouteProbes, lastRouteBackoffs, and routeAttempts, providing thread-safety and easy access to route-specific data.
2. Implement the cool-down period enforcement in the `shouldSkip()` method, ensuring that adjustments to connection pool sizes only occur after the cool-down period has passed.
3. Add route-specific backoff and probe attempts management to allow for better control over individual route behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #441: HTTPCLIENT-2270 - Introduce new LinearBackoffManager with cool-down period and route-specific attempts
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #441:
URL: https://github.com/apache/httpcomponents-client/pull/441#issuecomment-1536186449
@arturobernalg I am not a big fan of code re-use at all cost, especially if there are only two classes involved but I cannot help feeling that there are many commonalities between the `LinearBackoffManager` and `ExponentialBackoffManager` that may warrant having a common super class. At any rate I would propose HTTPCLIENT-2272 and HTTPCLIENT-2270 be folded into a single JIRA and a single PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] arturobernalg commented on pull request #441: HTTPCLIENT-2270 - Introduce new LinearBackoffManager with cool-down period and route-specific attempts
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #441:
URL: https://github.com/apache/httpcomponents-client/pull/441#issuecomment-1537218485
close in favor of https://github.com/apache/httpcomponents-client/pull/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #441: Title: Introduce new LinearBackoffManager with cool-down period and route-specific attempts
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #441:
URL: https://github.com/apache/httpcomponents-client/pull/441#issuecomment-1528988261
@arturobernalg Please _always_ include JIRA ticket in the title if there is a corresponding issue tracked in JIRA!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] arturobernalg closed pull request #441: HTTPCLIENT-2270 - Introduce new LinearBackoffManager with cool-down period and route-specific attempts
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg closed pull request #441: HTTPCLIENT-2270 - Introduce new LinearBackoffManager with cool-down period and route-specific attempts
URL: https://github.com/apache/httpcomponents-client/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org