You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/25 18:06:06 UTC

[GitHub] [spark] dongjoon-hyun commented on issue #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core`

dongjoon-hyun commented on issue #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core`
URL: https://github.com/apache/spark/pull/26658#issuecomment-558272876
 
 
   Hi, @srowen and @tgravescs .
   - The `commons-lang` of `core/pom.xml` is changed to `test` dependency. This is required with `-Phadoop-3.2`.
   - `Hive` module still needs `-Phive-1.2` or `-Phive-2.3`. It's because `sql/hive/pom.xml` is adding some dependencies with `hive-2.3`. For `Hive` module, it's natural to choose one of `-Phive-1.2` or `-Phive-2.3`. This PR is only focusing on `core` and `sql/core` module for now.
   ```
   $ git grep hive-2.3 | grep pom.xml
   pom.xml:      <id>hive-2.3</id>
   sql/hive/pom.xml:      <id>hive-2.3</id>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org