[GitHub] imay commented on a change in pull request #368: Add a frontend interface for committing RoutineLoadTask

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #368: Add a frontend interface for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r237430119
 
 

 ##########
 File path: gensrc/thrift/FrontendService.thrift
 ##########
 @@ -531,6 +531,22 @@ struct TLoadTxnRollbackResult {
     1: required Status.TStatus status
 }
 
+struct TRLTaskCommitRequest {
+    1: required string taskId
+    2: required i64 signature
+    3: required i64 backendId
+    4: required TLoadTxnCommitRequest loadTxnCommitRequest
+    // kafka progress such as {"partitionIdToOffset":{"1":100,"2",200}}
+    5: required string progress
 
 Review comment:
   you should define a struct for Kafka load progress

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org