You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2019/10/31 11:46:10 UTC

[VOTE] Release 4.10.0, release candidate #0

Hi everyone,
Please review and vote on the release candidate #0 for the version 4.10.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.10.0-rc0" [4] with git sha
2f08377f5c56f96389fb3a8e51844844537e118b

BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Enrico Olivelli

[1]
https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
[4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0

[RESULT] [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
I'm happy to announce that we have unanimously approved this release.

There are 7 approving votes, 3 of which are binding:

Sijie Guo
Jia Zhai
Enrico Olivelli
Guagning
Yong Zang
lan.liang

There are no disapproving votes.

I will proceed with the release procedure.
Artifacts on Maven Central will be available soon, the website will be
updated as soon as mirrors are in sync

Thanks everyone!
Enrico Olivelli

Il giorno mer 6 nov 2019 alle ore 12:39 Guangning E <eg...@gmail.com>
ha scritto:

> Good, +1  (non-binding)
>
> Thanks,
> Guangning
>
> Enrico Olivelli <eo...@gmail.com> 于2019年11月6日周三 下午4:06写道:
>
> > Guagning you reported a problem.
> > Is it a blocker for you ?
> > The fix has already been merged to master branch.
> >
> > Can you please cast your final vote ?
> >
> > Enrico
> >
> >
> > Il giorno mar 5 nov 2019 alle ore 20:48 Matteo Minardi <
> > minardi.matteo@hotmail.it> ha scritto:
> >
> > > +1
> > >
> > > The issue I committed for Bookkeeper Visual Manager (
> > > https://github.com/diennea/bookkeeper-visual-manager) works fine.
> > >
> > > Matteo.
> > >
> > > -----Messaggio originale-----
> > > Da: lan.liang <li...@163.com>
> > > Inviato: martedì 5 novembre 2019 17:52
> > > A: dev@bookkeeper.apache.org
> > > Oggetto: Re: [VOTE] Release 4.10.0, release candidate #0
> > >
> > > +1 no binding
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > - lan.liang
> > > On 11/6/2019 00:26,Enrico Olivelli<eo...@gmail.com> wrote:
> > > +1 (binding)
> > > Verified checksums and signatures.
> > > Built from sources with JDK13 on MacOs.
> > > Run tests on JDK8 + MacOs, tests are passing.
> > >
> > > Unit tests of HerdDB are passing:
> > > - I had a little problem in understanding how PlacementPolicyAdherence
> > > works
> > > - it is actually a nuisance that we are breaking PlacementPolicy APIs
> at
> > > every major release, but we already discussed this and I can live with
> > it)
> > >
> > > I have found a little issue in the new package bkctl, as we are not
> > > creating the directory "logs" the first time you run the tool you will
> > see
> > > an error (with JDK11+).
> > > https://github.com/apache/bookkeeper/issues/2197
> > >
> > > Personally I also find it annoying that by default the output of the
> tool
> > > is in "logs" and on stdout, it is very confusing for the user.
> > > I did not create an issue for this fact. Maybe it is better to start a
> > > discussion in a separate thread.
> > >
> > > Enrico
> > >
> > >
> > >
> > > Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com>
> > ha
> > > scritto:
> > >
> > > +1 (binding)
> > >
> > > Environment: macOS 10.14.2
> > >
> > > - verified packages checksum and signatures.
> > >
> > > - the source package build and test all run successfully.
> > >
> > > - in both binary package(server & all), 'bin/bookkeeper standalone' and
> > > 'bin/bookkeeper shell bookiesanity' runs well.
> > >
> > >
> > > Jia Zhai
> > >
> > > Beijing, China
> > >
> > > Mobile: +86 15810491983
> > >
> > >
> > >
> > >
> > > On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:
> > >
> > > +1 (binding)
> > >
> > > - verified signatures, shasum
> > > - build the source
> > > - binary can run
> > > - tag is good
> > > - release note is good.
> > >
> > > On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> > 4.10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1]
> > >
> > >
> > >
> > >
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > [2]
> > >
> > >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > [3]
> > >
> > >
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> > >
> > >
> > >
> > >
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Guangning E <eg...@gmail.com>.
Good, +1  (non-binding)

Thanks,
Guangning

Enrico Olivelli <eo...@gmail.com> 于2019年11月6日周三 下午4:06写道:

> Guagning you reported a problem.
> Is it a blocker for you ?
> The fix has already been merged to master branch.
>
> Can you please cast your final vote ?
>
> Enrico
>
>
> Il giorno mar 5 nov 2019 alle ore 20:48 Matteo Minardi <
> minardi.matteo@hotmail.it> ha scritto:
>
> > +1
> >
> > The issue I committed for Bookkeeper Visual Manager (
> > https://github.com/diennea/bookkeeper-visual-manager) works fine.
> >
> > Matteo.
> >
> > -----Messaggio originale-----
> > Da: lan.liang <li...@163.com>
> > Inviato: martedì 5 novembre 2019 17:52
> > A: dev@bookkeeper.apache.org
> > Oggetto: Re: [VOTE] Release 4.10.0, release candidate #0
> >
> > +1 no binding
> >
> >
> >
> >
> >
> >
> >
> >
> > - lan.liang
> > On 11/6/2019 00:26,Enrico Olivelli<eo...@gmail.com> wrote:
> > +1 (binding)
> > Verified checksums and signatures.
> > Built from sources with JDK13 on MacOs.
> > Run tests on JDK8 + MacOs, tests are passing.
> >
> > Unit tests of HerdDB are passing:
> > - I had a little problem in understanding how PlacementPolicyAdherence
> > works
> > - it is actually a nuisance that we are breaking PlacementPolicy APIs at
> > every major release, but we already discussed this and I can live with
> it)
> >
> > I have found a little issue in the new package bkctl, as we are not
> > creating the directory "logs" the first time you run the tool you will
> see
> > an error (with JDK11+).
> > https://github.com/apache/bookkeeper/issues/2197
> >
> > Personally I also find it annoying that by default the output of the tool
> > is in "logs" and on stdout, it is very confusing for the user.
> > I did not create an issue for this fact. Maybe it is better to start a
> > discussion in a separate thread.
> >
> > Enrico
> >
> >
> >
> > Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com>
> ha
> > scritto:
> >
> > +1 (binding)
> >
> > Environment: macOS 10.14.2
> >
> > - verified packages checksum and signatures.
> >
> > - the source package build and test all run successfully.
> >
> > - in both binary package(server & all), 'bin/bookkeeper standalone' and
> > 'bin/bookkeeper shell bookiesanity' runs well.
> >
> >
> > Jia Zhai
> >
> > Beijing, China
> >
> > Mobile: +86 15810491983
> >
> >
> >
> >
> > On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:
> >
> > +1 (binding)
> >
> > - verified signatures, shasum
> > - build the source
> > - binary can run
> > - tag is good
> > - release note is good.
> >
> > On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > Hi everyone,
> > Please review and vote on the release candidate #0 for the version
> 4.10.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.10.0-rc0" [4] with git sha
> > 2f08377f5c56f96389fb3a8e51844844537e118b
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1]
> >
> >
> >
> >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > [2]
> >
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > [3]
> >
> >
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> >
> >
> >
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
Guagning you reported a problem.
Is it a blocker for you ?
The fix has already been merged to master branch.

Can you please cast your final vote ?

Enrico


Il giorno mar 5 nov 2019 alle ore 20:48 Matteo Minardi <
minardi.matteo@hotmail.it> ha scritto:

> +1
>
> The issue I committed for Bookkeeper Visual Manager (
> https://github.com/diennea/bookkeeper-visual-manager) works fine.
>
> Matteo.
>
> -----Messaggio originale-----
> Da: lan.liang <li...@163.com>
> Inviato: martedì 5 novembre 2019 17:52
> A: dev@bookkeeper.apache.org
> Oggetto: Re: [VOTE] Release 4.10.0, release candidate #0
>
> +1 no binding
>
>
>
>
>
>
>
>
> - lan.liang
> On 11/6/2019 00:26,Enrico Olivelli<eo...@gmail.com> wrote:
> +1 (binding)
> Verified checksums and signatures.
> Built from sources with JDK13 on MacOs.
> Run tests on JDK8 + MacOs, tests are passing.
>
> Unit tests of HerdDB are passing:
> - I had a little problem in understanding how PlacementPolicyAdherence
> works
> - it is actually a nuisance that we are breaking PlacementPolicy APIs at
> every major release, but we already discussed this and I can live with it)
>
> I have found a little issue in the new package bkctl, as we are not
> creating the directory "logs" the first time you run the tool you will see
> an error (with JDK11+).
> https://github.com/apache/bookkeeper/issues/2197
>
> Personally I also find it annoying that by default the output of the tool
> is in "logs" and on stdout, it is very confusing for the user.
> I did not create an issue for this fact. Maybe it is better to start a
> discussion in a separate thread.
>
> Enrico
>
>
>
> Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com> ha
> scritto:
>
> +1 (binding)
>
> Environment: macOS 10.14.2
>
> - verified packages checksum and signatures.
>
> - the source package build and test all run successfully.
>
> - in both binary package(server & all), 'bin/bookkeeper standalone' and
> 'bin/bookkeeper shell bookiesanity' runs well.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:
>
> +1 (binding)
>
> - verified signatures, shasum
> - build the source
> - binary can run
> - tag is good
> - release note is good.
>
> On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> Hi everyone,
> Please review and vote on the release candidate #0 for the version 4.10.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.10.0-rc0" [4] with git sha
> 2f08377f5c56f96389fb3a8e51844844537e118b
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Enrico Olivelli
>
> [1]
>
>
>
>
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> [2]
>
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> [3]
>
>
>
>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
>
>
>
>

R: [VOTE] Release 4.10.0, release candidate #0

Posted by Matteo Minardi <mi...@hotmail.it>.
+1

The issue I committed for Bookkeeper Visual Manager (https://github.com/diennea/bookkeeper-visual-manager) works fine.

Matteo.

-----Messaggio originale-----
Da: lan.liang <li...@163.com> 
Inviato: martedì 5 novembre 2019 17:52
A: dev@bookkeeper.apache.org
Oggetto: Re: [VOTE] Release 4.10.0, release candidate #0

+1 no binding








- lan.liang
On 11/6/2019 00:26,Enrico Olivelli<eo...@gmail.com> wrote:
+1 (binding)
Verified checksums and signatures.
Built from sources with JDK13 on MacOs.
Run tests on JDK8 + MacOs, tests are passing.

Unit tests of HerdDB are passing:
- I had a little problem in understanding how PlacementPolicyAdherence works
- it is actually a nuisance that we are breaking PlacementPolicy APIs at every major release, but we already discussed this and I can live with it)

I have found a little issue in the new package bkctl, as we are not creating the directory "logs" the first time you run the tool you will see an error (with JDK11+).
https://github.com/apache/bookkeeper/issues/2197

Personally I also find it annoying that by default the output of the tool is in "logs" and on stdout, it is very confusing for the user.
I did not create an issue for this fact. Maybe it is better to start a discussion in a separate thread.

Enrico



Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com> ha
scritto:

+1 (binding)

Environment: macOS 10.14.2

- verified packages checksum and signatures.

- the source package build and test all run successfully.

- in both binary package(server & all), 'bin/bookkeeper standalone' and 'bin/bookkeeper shell bookiesanity' runs well.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:

+1 (binding)

- verified signatures, shasum
- build the source
- binary can run
- tag is good
- release note is good.

On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
wrote:

Hi everyone,
Please review and vote on the release candidate #0 for the version 4.10.0, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.10.0-rc0" [4] with git sha 2f08377f5c56f96389fb3a8e51844844537e118b

BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think it is important to a release.

The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.

Thanks,
Enrico Olivelli

[1]



https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
[2]

https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
[3]



https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
[4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0




Re: [VOTE] Release 4.10.0, release candidate #0

Posted by "lan.liang" <li...@163.com>.
+1 no binding








- lan.liang
On 11/6/2019 00:26,Enrico Olivelli<eo...@gmail.com> wrote:
+1 (binding)
Verified checksums and signatures.
Built from sources with JDK13 on MacOs.
Run tests on JDK8 + MacOs, tests are passing.

Unit tests of HerdDB are passing:
- I had a little problem in understanding how PlacementPolicyAdherence works
- it is actually a nuisance that we are breaking PlacementPolicy APIs at
every major release, but we already discussed this and I can live with it)

I have found a little issue in the new package bkctl, as we are not
creating the directory "logs" the first time you run the tool you will see
an error (with JDK11+).
https://github.com/apache/bookkeeper/issues/2197

Personally I also find it annoying that by default the output of the tool
is in "logs" and on stdout, it is very confusing for the user.
I did not create an issue for this fact. Maybe it is better to start a
discussion in a separate thread.

Enrico



Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com> ha
scritto:

+1 (binding)

Environment: macOS 10.14.2

- verified packages checksum and signatures.

- the source package build and test all run successfully.

- in both binary package(server & all), 'bin/bookkeeper standalone' and
'bin/bookkeeper shell bookiesanity' runs well.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:

+1 (binding)

- verified signatures, shasum
- build the source
- binary can run
- tag is good
- release note is good.

On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
wrote:

Hi everyone,
Please review and vote on the release candidate #0 for the version
4.10.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.10.0-rc0" [4] with git sha
2f08377f5c56f96389fb3a8e51844844537e118b

BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you
think
it is important to a release.

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Enrico Olivelli

[1]



https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
[2]

https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
[3]



https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
[4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0




Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
Verified checksums and signatures.
Built from sources with JDK13 on MacOs.
Run tests on JDK8 + MacOs, tests are passing.

Unit tests of HerdDB are passing:
- I had a little problem in understanding how PlacementPolicyAdherence works
- it is actually a nuisance that we are breaking PlacementPolicy APIs at
every major release, but we already discussed this and I can live with it)

I have found a little issue in the new package bkctl, as we are not
creating the directory "logs" the first time you run the tool you will see
an error (with JDK11+).
https://github.com/apache/bookkeeper/issues/2197

Personally I also find it annoying that by default the output of the tool
is in "logs" and on stdout, it is very confusing for the user.
I did not create an issue for this fact. Maybe it is better to start a
discussion in a separate thread.

Enrico



Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zh...@gmail.com> ha
scritto:

> +1 (binding)
>
> Environment: macOS 10.14.2
>
> - verified packages checksum and signatures.
>
> - the source package build and test all run successfully.
>
> - in both binary package(server & all), 'bin/bookkeeper standalone' and
> 'bin/bookkeeper shell bookiesanity' runs well.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > - verified signatures, shasum
> > - build the source
> > - binary can run
> > - tag is good
> > - release note is good.
> >
> > On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> > 4.10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1]
> > >
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > [2]
> > >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > [3]
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> > >
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Jia Zhai <zh...@gmail.com>.
+1 (binding)

Environment: macOS 10.14.2

- verified packages checksum and signatures.

- the source package build and test all run successfully.

- in both binary package(server & all), 'bin/bookkeeper standalone' and
'bin/bookkeeper shell bookiesanity' runs well.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <gu...@gmail.com> wrote:

> +1 (binding)
>
> - verified signatures, shasum
> - build the source
> - binary can run
> - tag is good
> - release note is good.
>
> On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hi everyone,
> > Please review and vote on the release candidate #0 for the version
> 4.10.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.10.0-rc0" [4] with git sha
> > 2f08377f5c56f96389fb3a8e51844844537e118b
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1]
> >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > [3]
> >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Sijie Guo <gu...@gmail.com>.
+1 (binding)

- verified signatures, shasum
- build the source
- binary can run
- tag is good
- release note is good.

On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eo...@gmail.com> wrote:

> Hi everyone,
> Please review and vote on the release candidate #0 for the version 4.10.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.10.0-rc0" [4] with git sha
> 2f08377f5c56f96389fb3a8e51844844537e118b
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Enrico Olivelli
>
> [1]
>
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> [3]
>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Yong Zhang <zh...@gmail.com>.
It's ok for me.

+1 (non-binding)


Thanks,
Yong

On Sat, Nov 2, 2019 at 18:01 Enrico Olivelli <eo...@gmail.com> wrote:

> Yong Zang,
> Thank you for reporting this problem.
> I can reproduce your problem and it is releated to the lack of -Dtwitter in
> bin/common.sh
>
> Personally I don't this this is a blocker for a release as I feel that the
> ability to run the server without explicitly building the sources is not
> very useful in every day work.
> Users usually use binaries/docker images and developers usually build the
> source from Maven or the IDE.
>
> That said I will send a PR with the fix and maybe we can fix in a 4.10.1
> release or in case this RC fails and we have to send a new RC out for vote.
>
> If this is a blocker problem for you or anyone else please chime in.
>
> Enrico
>
> Il giorno ven 1 nov 2019 alle ore 06:26 Yong Zhang <
> zhangyong1025.zy@gmail.com> ha scritto:
>
> > Hi Enrico,
> >
> > I verify the release candidate:
> >
> > - verify shasum of the source package and binary package
> > - using binary package to start a standalone service is good
> > - using the library to test the write and read are good
> >
> > But there are something wrong when I running standalone service after
> > building the source packages.I ‘m not sure if that problem is caused by
> > my operations.
> >
> > ```
> > ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> > ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'stream/server' is not found, generating it ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'stream/server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> > org.apache.bookkeeper.stream.cluster.StandaloneStarter
> > ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'bookkeeper-server' is not found, generating it
> ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'bookkeeper-server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> org.apache.bookkeeper.server.Main
> > ```
> >
> > Using binary package the standalone service starts well. And using the
> > master code to build it the service starts well too. When I checkout to
> > v4.10.0-rc0 and rebuild it, the same problem appears.
> >
> >
> >
> > Thanks,
> > Yong
> >
> > ---
> > > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> > 4.10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1]
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > [3]
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> >
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
Yong Zang,
Thank you for reporting this problem.
I can reproduce your problem and it is releated to the lack of -Dtwitter in
bin/common.sh

Personally I don't this this is a blocker for a release as I feel that the
ability to run the server without explicitly building the sources is not
very useful in every day work.
Users usually use binaries/docker images and developers usually build the
source from Maven or the IDE.

That said I will send a PR with the fix and maybe we can fix in a 4.10.1
release or in case this RC fails and we have to send a new RC out for vote.

If this is a blocker problem for you or anyone else please chime in.

Enrico

Il giorno ven 1 nov 2019 alle ore 06:26 Yong Zhang <
zhangyong1025.zy@gmail.com> ha scritto:

> Hi Enrico,
>
> I verify the release candidate:
>
> - verify shasum of the source package and binary package
> - using binary package to start a standalone service is good
> - using the library to test the write and read are good
>
> But there are something wrong when I running standalone service after
> building the source packages.I ‘m not sure if that problem is caused by
> my operations.
>
> ```
> ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> the classpath of module 'stream/server' is not found, generating it ...
> see output at
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> for the progress ...
> the classpath of module 'stream/server' is generated at
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> Error: Could not find or load main class
> org.apache.bookkeeper.stream.cluster.StandaloneStarter
> ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> the classpath of module 'bookkeeper-server' is not found, generating it ...
> see output at
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> for the progress ...
> the classpath of module 'bookkeeper-server' is generated at
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> Error: Could not find or load main class org.apache.bookkeeper.server.Main
> ```
>
> Using binary package the standalone service starts well. And using the
> master code to build it the service starts well too. When I checkout to
> v4.10.0-rc0 and rebuild it, the same problem appears.
>
>
>
> Thanks,
> Yong
>
> ---
> > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > Hi everyone,
> > Please review and vote on the release candidate #0 for the version
> 4.10.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.10.0-rc0" [4] with git sha
> > 2f08377f5c56f96389fb3a8e51844844537e118b
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1]
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > [3]
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
>
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
Il ven 1 nov 2019, 11:11 Guangning E <eg...@gmail.com> ha scritto:

> I can pass based on branch-4.10, but I reported the following error in Tag
> v4.10.0-rc0
>
> Used command:
> mvn clean install -DskipTests -Dstream -Dtwitter
>
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time:  01:46 min
> [INFO] Finished at: 2019-11-01T18:00:05+08:00
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project twitter-science-provider: Could
> not resolve dependencies for project
> org.apache.bookkeeper.stats:twitter-science-provider:jar:4.10.0: The
> following artifacts could not be resolved:
> com.twitter.common:stats:jar:0.0.64,
> com.twitter.common:stat-registry:jar:0.0.10,
> com.twitter.common:stat:jar:0.0.11,
> com.twitter.common:stats-provider:jar:0.0.36,
> com.twitter.common:application-action:jar:0.0.44,
> com.twitter.common:net-util:jar:0.0.49, com.twitter.common:base:jar:0.0.57,
> com.twitter.common:util-system-mocks:jar:0.0.43,
> com.twitter.common:collections:jar:0.0.48,
> com.twitter.common:quantity:jar:0.0.44,
> com.twitter.common:util-sampler:jar:0.0.33,
> com.twitter.common:net-http-handlers:jar:0.0.39,
> com.twitter.common:net-http-handlers-text:jar:0.0.20,
> com.twitter.common:net-http-handlers-string-template:jar:0.0.26,
> com.twitter.common:util-templating:jar:0.0.2,
> com.twitter.common:stats-time-series:jar:0.0.36,
> com.twitter.common:stats-jvm:jar:0.0.33: Failure to find
> com.twitter.common:stats:jar:0.0.64 in https://maven.twttr.com was cached
> in the local repository, resolution will not be reattempted until the
> update interval of twitter has elapsed or updates are forced -> [Help 1]
>

Maybe you have problems with Twitter repo


Enrico


> Yong Zhang <zh...@gmail.com> 于2019年11月1日周五 下午1:26写道:
>
> > Hi Enrico,
> >
> > I verify the release candidate:
> >
> > - verify shasum of the source package and binary package
> > - using binary package to start a standalone service is good
> > - using the library to test the write and read are good
> >
> > But there are something wrong when I running standalone service after
> > building the source packages.I ‘m not sure if that problem is caused by
> > my operations.
> >
> > ```
> > ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> > ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'stream/server' is not found, generating it ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'stream/server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> > org.apache.bookkeeper.stream.cluster.StandaloneStarter
> > ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'bookkeeper-server' is not found, generating it
> ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'bookkeeper-server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> org.apache.bookkeeper.server.Main
> > ```
> >
> > Using binary package the standalone service starts well. And using the
> > master code to build it the service starts well too. When I checkout to
> > v4.10.0-rc0 and rebuild it, the same problem appears.
> >
> >
> >
> > Thanks,
> > Yong
> >
> > ---
> > > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> > 4.10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1]
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > [3]
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> >
> >
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
Karan,
thank you for your help.
I started a new email thread with an answer.

Enrico


Il giorno ven 1 nov 2019 alle ore 19:37 Karan Mehta
<k....@salesforce.com.invalid> ha scritto:

> I am interested in putting up a (non-binding) vote.
> Can someone share the typical steps that are involved? The basic ones are
> download artifacts, verify checksums, build (don't know special commands
> here), smoke test etc.
>
>
> On Fri, Nov 1, 2019 at 3:11 AM Guangning E <eg...@gmail.com> wrote:
>
> > I can pass based on branch-4.10, but I reported the following error in
> Tag
> > v4.10.0-rc0
> >
> > Used command:
> > mvn clean install -DskipTests -Dstream -Dtwitter
> >
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Total time:  01:46 min
> > [INFO] Finished at: 2019-11-01T18:00:05+08:00
> > [INFO]
> > ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal on project twitter-science-provider: Could
> > not resolve dependencies for project
> > org.apache.bookkeeper.stats:twitter-science-provider:jar:4.10.0: The
> > following artifacts could not be resolved:
> > com.twitter.common:stats:jar:0.0.64,
> > com.twitter.common:stat-registry:jar:0.0.10,
> > com.twitter.common:stat:jar:0.0.11,
> > com.twitter.common:stats-provider:jar:0.0.36,
> > com.twitter.common:application-action:jar:0.0.44,
> > com.twitter.common:net-util:jar:0.0.49,
> com.twitter.common:base:jar:0.0.57,
> > com.twitter.common:util-system-mocks:jar:0.0.43,
> > com.twitter.common:collections:jar:0.0.48,
> > com.twitter.common:quantity:jar:0.0.44,
> > com.twitter.common:util-sampler:jar:0.0.33,
> > com.twitter.common:net-http-handlers:jar:0.0.39,
> > com.twitter.common:net-http-handlers-text:jar:0.0.20,
> > com.twitter.common:net-http-handlers-string-template:jar:0.0.26,
> > com.twitter.common:util-templating:jar:0.0.2,
> > com.twitter.common:stats-time-series:jar:0.0.36,
> > com.twitter.common:stats-jvm:jar:0.0.33: Failure to find
> > com.twitter.common:stats:jar:0.0.64 in https://maven.twttr.com was
> cached
> > in the local repository, resolution will not be reattempted until the
> > update interval of twitter has elapsed or updates are forced -> [Help 1]
> >
> > Yong Zhang <zh...@gmail.com> 于2019年11月1日周五 下午1:26写道:
> >
> > > Hi Enrico,
> > >
> > > I verify the release candidate:
> > >
> > > - verify shasum of the source package and binary package
> > > - using binary package to start a standalone service is good
> > > - using the library to test the write and read are good
> > >
> > > But there are something wrong when I running standalone service after
> > > building the source packages.I ‘m not sure if that problem is caused by
> > > my operations.
> > >
> > > ```
> > > ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> > > ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> > > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > > the classpath of module 'stream/server' is not found, generating it ...
> > > see output at
> > >
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> > > for the progress ...
> > > the classpath of module 'stream/server' is generated at
> > >
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> > > Error: Could not find or load main class
> > > org.apache.bookkeeper.stream.cluster.StandaloneStarter
> > > ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> > > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > > the classpath of module 'bookkeeper-server' is not found, generating it
> > ...
> > > see output at
> > >
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> > > for the progress ...
> > > the classpath of module 'bookkeeper-server' is generated at
> > >
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> > > Error: Could not find or load main class
> > org.apache.bookkeeper.server.Main
> > > ```
> > >
> > > Using binary package the standalone service starts well. And using the
> > > master code to build it the service starts well too. When I checkout to
> > > v4.10.0-rc0 and rebuild it, the same problem appears.
> > >
> > >
> > >
> > > Thanks,
> > > Yong
> > >
> > > ---
> > > > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #0 for the version
> > > 4.10.0,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * Release notes [1]
> > > > * The official Apache source and binary distributions to be deployed
> to
> > > > dist.apache.org [2]
> > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > > >
> > > > BookKeeper's KEYS file contains PGP keys we used to sign this
> release:
> > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > >
> > > > Please download these packages and review this release candidate:
> > > >
> > > > - Review release notes
> > > > - Download the source package (verify shasum, and asc) and follow the
> > > > instructions to build and run the bookkeeper service.
> > > > - Download the binary package (verify shasum, and asc) and follow the
> > > > instructions to run the bookkeeper service.
> > > > - Review maven repo, release tag, licenses, and any other things you
> > > think
> > > > it is important to a release.
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Enrico Olivelli
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > > [2]
> > >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > > [3]
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> > >
> > >
> >
>
>
> --
> Karan Mehta
>
> <http://smart.salesforce.com/sig/k.mehta//us_mb/default/link.html>
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Karan Mehta <k....@salesforce.com.INVALID>.
I am interested in putting up a (non-binding) vote.
Can someone share the typical steps that are involved? The basic ones are
download artifacts, verify checksums, build (don't know special commands
here), smoke test etc.


On Fri, Nov 1, 2019 at 3:11 AM Guangning E <eg...@gmail.com> wrote:

> I can pass based on branch-4.10, but I reported the following error in Tag
> v4.10.0-rc0
>
> Used command:
> mvn clean install -DskipTests -Dstream -Dtwitter
>
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time:  01:46 min
> [INFO] Finished at: 2019-11-01T18:00:05+08:00
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project twitter-science-provider: Could
> not resolve dependencies for project
> org.apache.bookkeeper.stats:twitter-science-provider:jar:4.10.0: The
> following artifacts could not be resolved:
> com.twitter.common:stats:jar:0.0.64,
> com.twitter.common:stat-registry:jar:0.0.10,
> com.twitter.common:stat:jar:0.0.11,
> com.twitter.common:stats-provider:jar:0.0.36,
> com.twitter.common:application-action:jar:0.0.44,
> com.twitter.common:net-util:jar:0.0.49, com.twitter.common:base:jar:0.0.57,
> com.twitter.common:util-system-mocks:jar:0.0.43,
> com.twitter.common:collections:jar:0.0.48,
> com.twitter.common:quantity:jar:0.0.44,
> com.twitter.common:util-sampler:jar:0.0.33,
> com.twitter.common:net-http-handlers:jar:0.0.39,
> com.twitter.common:net-http-handlers-text:jar:0.0.20,
> com.twitter.common:net-http-handlers-string-template:jar:0.0.26,
> com.twitter.common:util-templating:jar:0.0.2,
> com.twitter.common:stats-time-series:jar:0.0.36,
> com.twitter.common:stats-jvm:jar:0.0.33: Failure to find
> com.twitter.common:stats:jar:0.0.64 in https://maven.twttr.com was cached
> in the local repository, resolution will not be reattempted until the
> update interval of twitter has elapsed or updates are forced -> [Help 1]
>
> Yong Zhang <zh...@gmail.com> 于2019年11月1日周五 下午1:26写道:
>
> > Hi Enrico,
> >
> > I verify the release candidate:
> >
> > - verify shasum of the source package and binary package
> > - using binary package to start a standalone service is good
> > - using the library to test the write and read are good
> >
> > But there are something wrong when I running standalone service after
> > building the source packages.I ‘m not sure if that problem is caused by
> > my operations.
> >
> > ```
> > ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> > ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'stream/server' is not found, generating it ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'stream/server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> > org.apache.bookkeeper.stream.cluster.StandaloneStarter
> > ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> > JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> > the classpath of module 'bookkeeper-server' is not found, generating it
> ...
> > see output at
> >
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> > for the progress ...
> > the classpath of module 'bookkeeper-server' is generated at
> >
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> > Error: Could not find or load main class
> org.apache.bookkeeper.server.Main
> > ```
> >
> > Using binary package the standalone service starts well. And using the
> > master code to build it the service starts well too. When I checkout to
> > v4.10.0-rc0 and rebuild it, the same problem appears.
> >
> >
> >
> > Thanks,
> > Yong
> >
> > ---
> > > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> > 4.10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.10.0-rc0" [4] with git sha
> > > 2f08377f5c56f96389fb3a8e51844844537e118b
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1]
> > >
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > > [3]
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
> >
> >
>


-- 
Karan Mehta

<http://smart.salesforce.com/sig/k.mehta//us_mb/default/link.html>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Guangning E <eg...@gmail.com>.
I can pass based on branch-4.10, but I reported the following error in Tag
v4.10.0-rc0

Used command:
mvn clean install -DskipTests -Dstream -Dtwitter

[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time:  01:46 min
[INFO] Finished at: 2019-11-01T18:00:05+08:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal on project twitter-science-provider: Could
not resolve dependencies for project
org.apache.bookkeeper.stats:twitter-science-provider:jar:4.10.0: The
following artifacts could not be resolved:
com.twitter.common:stats:jar:0.0.64,
com.twitter.common:stat-registry:jar:0.0.10,
com.twitter.common:stat:jar:0.0.11,
com.twitter.common:stats-provider:jar:0.0.36,
com.twitter.common:application-action:jar:0.0.44,
com.twitter.common:net-util:jar:0.0.49, com.twitter.common:base:jar:0.0.57,
com.twitter.common:util-system-mocks:jar:0.0.43,
com.twitter.common:collections:jar:0.0.48,
com.twitter.common:quantity:jar:0.0.44,
com.twitter.common:util-sampler:jar:0.0.33,
com.twitter.common:net-http-handlers:jar:0.0.39,
com.twitter.common:net-http-handlers-text:jar:0.0.20,
com.twitter.common:net-http-handlers-string-template:jar:0.0.26,
com.twitter.common:util-templating:jar:0.0.2,
com.twitter.common:stats-time-series:jar:0.0.36,
com.twitter.common:stats-jvm:jar:0.0.33: Failure to find
com.twitter.common:stats:jar:0.0.64 in https://maven.twttr.com was cached
in the local repository, resolution will not be reattempted until the
update interval of twitter has elapsed or updates are forced -> [Help 1]

Yong Zhang <zh...@gmail.com> 于2019年11月1日周五 下午1:26写道:

> Hi Enrico,
>
> I verify the release candidate:
>
> - verify shasum of the source package and binary package
> - using binary package to start a standalone service is good
> - using the library to test the write and read are good
>
> But there are something wrong when I running standalone service after
> building the source packages.I ‘m not sure if that problem is caused by
> my operations.
>
> ```
> ➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
> ➜  bookkeeper-4.10.0 bin/bookkeeper standalone
> JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> the classpath of module 'stream/server' is not found, generating it ...
> see output at
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out
> for the progress ...
> the classpath of module 'stream/server' is generated at
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
> Error: Could not find or load main class
> org.apache.bookkeeper.stream.cluster.StandaloneStarter
> ➜  bookkeeper-4.10.0 bin/bookkeeper bookie
> JAVA_HOME not set, using java from PATH. (/usr/bin/java)
> the classpath of module 'bookkeeper-server' is not found, generating it ...
> see output at
> /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out
> for the progress ...
> the classpath of module 'bookkeeper-server' is generated at
> '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
> Error: Could not find or load main class org.apache.bookkeeper.server.Main
> ```
>
> Using binary package the standalone service starts well. And using the
> master code to build it the service starts well too. When I checkout to
> v4.10.0-rc0 and rebuild it, the same problem appears.
>
>
>
> Thanks,
> Yong
>
> ---
> > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > Hi everyone,
> > Please review and vote on the release candidate #0 for the version
> 4.10.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.10.0-rc0" [4] with git sha
> > 2f08377f5c56f96389fb3a8e51844844537e118b
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1]
> >
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> > [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> > [3]
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0
>
>

Re: [VOTE] Release 4.10.0, release candidate #0

Posted by Yong Zhang <zh...@gmail.com>.
Hi Enrico,

I verify the release candidate:

- verify shasum of the source package and binary package
- using binary package to start a standalone service is good
- using the library to test the write and read are good

But there are something wrong when I running standalone service after 
building the source packages.I ‘m not sure if that problem is caused by 
my operations.

```
➜  bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream
➜  bookkeeper-4.10.0 bin/bookkeeper standalone
JAVA_HOME not set, using java from PATH. (/usr/bin/java)
the classpath of module 'stream/server' is not found, generating it ...
see output at /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out for the progress ...
the classpath of module 'stream/server' is generated at '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'.
Error: Could not find or load main class org.apache.bookkeeper.stream.cluster.StandaloneStarter
➜  bookkeeper-4.10.0 bin/bookkeeper bookie
JAVA_HOME not set, using java from PATH. (/usr/bin/java)
the classpath of module 'bookkeeper-server' is not found, generating it ...
see output at /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out for the progress ...
the classpath of module 'bookkeeper-server' is generated at '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'.
Error: Could not find or load main class org.apache.bookkeeper.server.Main
```

Using binary package the standalone service starts well. And using the 
master code to build it the service starts well too. When I checkout to 
v4.10.0-rc0 and rebuild it, the same problem appears.



Thanks,
Yong

---
> On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> 
> Hi everyone,
> Please review and vote on the release candidate #0 for the version 4.10.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.10.0-rc0" [4] with git sha
> 2f08377f5c56f96389fb3a8e51844844537e118b
> 
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> 
> Please download these packages and review this release candidate:
> 
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
> 
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Enrico Olivelli
> 
> [1]
> https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a
> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/
> [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0