[GitHub] [calcite] asolimando commented on a diff in pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

[GitBox <gi...@apache.org>]

asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1027756107


##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##########
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
     return mq.getExpressionLineage(rel.getInput(), outputExpression);
   }
 
+  /**
+   * Expression lineage from Snapshot.
+   */

Review Comment:
   I know that none of the other methods in the class have it, but I think it's important to have proper javadoc for public methods of this kind, something along this format:
   ```
     /**
      * Expression lineage from Snapshot.
      * @param rel
      * @param mq
      * @param outputExpression
      * @return
      */
   ```
   What do you think Jiajun?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org