You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@giraph.apache.org by Claudio Martella <cl...@gmail.com> on 2011/09/14 12:06:40 UTC
trunk doesn't build because of header license missing
I don't know if this issue is worth a JIRA+patch, so I post it here.
maven install fails as rat is complaining about missing licenses.
Basically GraphState.java is missing Apache license header.
Best,
--
Claudio Martella
claudio.martella@gmail.com
Re: trunk doesn't build because of header license missing
Posted by Jake Mannix <ja...@gmail.com>.
Yeah, my bad as well, I actually had that header in my GitHub branch, but
somehow didn't get it into the patch - I did mvn install, I promise! :)
On Wed, Sep 14, 2011 at 8:53 AM, Avery Ching <ac...@apache.org> wrote:
> And committers too (my bad) =).
>
>
> On 9/14/11 8:49 AM, Owen O'Malley wrote:
>
>> On Wed, Sep 14, 2011 at 4:08 AM, Hyunsik Choi<hy...@apache.org> wrote:
>>
>>> Thank you for reporting.
>>>
>> As a reminder to devs, you should ensure that mvn install succeeds
>> before committing the patch. *smile*
>>
>> -- Owen
>>
>
>
Re: trunk doesn't build because of header license missing
Posted by Avery Ching <ac...@apache.org>.
And committers too (my bad) =).
On 9/14/11 8:49 AM, Owen O'Malley wrote:
> On Wed, Sep 14, 2011 at 4:08 AM, Hyunsik Choi<hy...@apache.org> wrote:
>> Thank you for reporting.
> As a reminder to devs, you should ensure that mvn install succeeds
> before committing the patch. *smile*
>
> -- Owen
Re: trunk doesn't build because of header license missing
Posted by Hyunsik Choi <hy...@apache.org>.
I also have overlooked that.
Later, I will always check 'mvn install'. :)
--
Hyunsik Choi
On Thu, Sep 15, 2011 at 12:49 AM, Owen O'Malley <ow...@hortonworks.com> wrote:
> On Wed, Sep 14, 2011 at 4:08 AM, Hyunsik Choi <hy...@apache.org> wrote:
>> Thank you for reporting.
>
> As a reminder to devs, you should ensure that mvn install succeeds
> before committing the patch. *smile*
>
> -- Owen
>
Re: trunk doesn't build because of header license missing
Posted by Owen O'Malley <ow...@hortonworks.com>.
On Wed, Sep 14, 2011 at 4:08 AM, Hyunsik Choi <hy...@apache.org> wrote:
> Thank you for reporting.
As a reminder to devs, you should ensure that mvn install succeeds
before committing the patch. *smile*
-- Owen
Re: trunk doesn't build because of header license missing
Posted by Hyunsik Choi <hy...@apache.org>.
Thank you for reporting.
Yes, this is trial issue, but necessary.
For recording, I just created a jira issue:
https://issues.apache.org/jira/browse/GIRAPH-33
--
Hyunsik Choi
On Wed, Sep 14, 2011 at 7:06 PM, Claudio Martella
<cl...@gmail.com> wrote:
> I don't know if this issue is worth a JIRA+patch, so I post it here.
>
> maven install fails as rat is complaining about missing licenses.
> Basically GraphState.java is missing Apache license header.
>
> Best,
>
>
> --
> Claudio Martella
> claudio.martella@gmail.com
>