[GitHub] [fineract] ivan333m opened a new pull request #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version

[GitBox <gi...@apache.org>]

ivan333m opened a new pull request #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642
 
 
   This is upgrade of Spring Boot, Spring, Spring Security, OpenJpa and other related libraries to their latest versions. 
   All Integrations tests are passing with the new commits. But I would like to describe issues I have encountered during development:
   1) Spring security does not support custom SaltSource. it is now random generated. So I used MessageDigestPasswordEncoder and V353__migrate_passwords_to_ss_5.sql for password migration.
   2) There is huge trobule with OpenJpa and Spring5 compatibility. OpenJpaVendorAdapter was removed from Spring5. (See:  https://jira.spring.io/browse/SPR-16035?redirect=false&focusedCommentId=160186&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel) So I have upgraded OpenJpa and moved some code from spring 4 to fineract project. This solution has to be reviewed twice. I do not like it but this is the only way I have made it works. I have tried without jpaVendorAdapter but it leads to:
   `"SQLException: Lock wait timeout exceeded; try restarting transaction"`
   
   3) Alot of issues I had with dependencies.gradle and dev-dependencies.gradle they have alot of duplicates and dev is out of date. I think after Tomcat removal we could will leave only dependencies.gradle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services