You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/20 18:04:11 UTC
[GitHub] [incubator-yunikorn-web] akhilpb001 opened a new pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web
akhilpb001 opened a new pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on a change in pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48#discussion_r510188128
##########
File path: Dockerfile.dev
##########
@@ -9,20 +7,32 @@
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
Review comment:
removed the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on a change in pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48#discussion_r510187933
##########
File path: Makefile
##########
@@ -94,6 +74,32 @@ clean:
rm -rf ./out
rm -rf ./out-tsc
+# Build an image based on the dev build version
+.PHONY: dev-image
+dev-image:
+ docker build -t ${REGISTRY}/yunikorn-web:dev-${VERSION} -f ./Dockerfile.dev .
+
+# Run the web interface from the dev build image
+.PHONY: dev-run-image
Review comment:
removed this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] sunilgovind commented on a change in pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web
Posted by GitBox <gi...@apache.org>.
sunilgovind commented on a change in pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48#discussion_r509955969
##########
File path: Dockerfile.dev
##########
@@ -9,20 +7,32 @@
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
Review comment:
unwanted line of change.
##########
File path: Makefile
##########
@@ -94,6 +74,32 @@ clean:
rm -rf ./out
rm -rf ./out-tsc
+# Build an image based on the dev build version
+.PHONY: dev-image
+dev-image:
+ docker build -t ${REGISTRY}/yunikorn-web:dev-${VERSION} -f ./Dockerfile.dev .
+
+# Run the web interface from the dev build image
+.PHONY: dev-run-image
Review comment:
lets call it as run-image?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 merged pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web
Posted by GitBox <gi...@apache.org>.
akhilpb001 merged pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org