You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/19 13:18:43 UTC
[GitHub] [beam] riteshghorse commented on a diff in pull request #17370: [BEAM-14306] Add unit testing to pane coder
riteshghorse commented on code in PR #17370:
URL: https://github.com/apache/beam/pull/17370#discussion_r853056352
##########
sdks/go/pkg/beam/core/graph/coder/panes.go:
##########
@@ -60,11 +64,11 @@ func EncodePane(v typex.PaneInfo, w io.Writer) error {
func NewPane(b byte) typex.PaneInfo {
pn := typex.NoFiringPane()
- if b&0x01 == 1 {
- pn.IsFirst = true
+ if !(b&0x02 == 2) {
+ pn.IsFirst = false
Review Comment:
This should be set as true?
##########
sdks/go/pkg/beam/core/graph/coder/panes.go:
##########
@@ -60,11 +64,11 @@ func EncodePane(v typex.PaneInfo, w io.Writer) error {
func NewPane(b byte) typex.PaneInfo {
pn := typex.NoFiringPane()
- if b&0x01 == 1 {
- pn.IsFirst = true
+ if !(b&0x02 == 2) {
+ pn.IsFirst = false
}
- if b&0x02 == 2 {
- pn.IsLast = true
+ if !(b&0x01 == 1) {
+ pn.IsLast = false
Review Comment:
This should be set as true?
##########
sdks/go/pkg/beam/core/graph/coder/panes.go:
##########
@@ -60,11 +64,11 @@ func EncodePane(v typex.PaneInfo, w io.Writer) error {
func NewPane(b byte) typex.PaneInfo {
pn := typex.NoFiringPane()
- if b&0x01 == 1 {
- pn.IsFirst = true
+ if !(b&0x02 == 2) {
+ pn.IsFirst = false
}
- if b&0x02 == 2 {
- pn.IsLast = true
+ if !(b&0x01 == 1) {
+ pn.IsLast = false
Review Comment:
This should be set as true?
##########
sdks/go/pkg/beam/core/graph/coder/panes_test.go:
##########
@@ -0,0 +1,178 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coder
+
+import (
+ "bytes"
+ "math"
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/typex"
+)
+
+func makePaneInfo(timing typex.PaneTiming, first, last bool, index, nsIndex int64) typex.PaneInfo {
+ return typex.PaneInfo{Timing: timing, IsFirst: first, IsLast: last, Index: index, NonSpeculativeIndex: nsIndex}
+}
+
+func equalPanes(left, right typex.PaneInfo) bool {
+ return (left.Timing == right.Timing) && (left.IsFirst == right.IsFirst) && (left.IsLast == right.IsLast) && (left.Index == right.Index) && (left.NonSpeculativeIndex == right.NonSpeculativeIndex)
+}
+
+func TestPaneCoder(t *testing.T) {
+ tests := []struct {
+ name string
+ timing typex.PaneTiming
+ first bool
+ last bool
+ index int64
+ nsIndex int64
+ }{
+ {
+ "false bools",
+ typex.PaneUnknown,
+ false,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "true bools",
+ typex.PaneUnknown,
+ true,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "first pane",
+ typex.PaneUnknown,
+ true,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "last pane",
+ typex.PaneUnknown,
+ false,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "on time, different index and non-speculative",
+ typex.PaneOnTime,
+ false,
+ false,
+ 1,
+ 2,
+ },
+ {
+ "valid early pane",
+ typex.PaneEarly,
+ true,
+ false,
+ math.MaxInt64,
+ -1,
+ },
+ {
+ "on time, max non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MaxInt64,
+ },
+ {
+ "late pane, max index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MaxInt64,
+ 0,
+ },
+ {
+ "on time, min non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MinInt64,
+ },
+ {
+ "late, min index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MinInt64,
+ 0,
+ },
+ }
+ for _, test := range tests {
+ t.Run(test.name, func(t *testing.T) {
+ input := makePaneInfo(test.timing, test.first, test.last, test.index, test.nsIndex)
+ var buf bytes.Buffer
+ err := EncodePane(input, &buf)
+ if err != nil {
+ t.Fatalf("failed to encode pane %v, got %v", input, err)
+ }
+ got, err := DecodePane(&buf)
+ if err != nil {
+ t.Fatalf("failed to decode pane from buffer %v, got %v", buf, err)
+ }
+ if want := input; !equalPanes(got, want) {
+ t.Errorf("got pane %v, want %v", got, want)
+ }
+ })
+ }
+}
+func TestEncodePane_bad(t *testing.T) {
Review Comment:
add empty line
##########
sdks/go/pkg/beam/core/graph/coder/panes_test.go:
##########
@@ -0,0 +1,178 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coder
+
+import (
+ "bytes"
+ "math"
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/typex"
+)
+
+func makePaneInfo(timing typex.PaneTiming, first, last bool, index, nsIndex int64) typex.PaneInfo {
+ return typex.PaneInfo{Timing: timing, IsFirst: first, IsLast: last, Index: index, NonSpeculativeIndex: nsIndex}
+}
+
+func equalPanes(left, right typex.PaneInfo) bool {
+ return (left.Timing == right.Timing) && (left.IsFirst == right.IsFirst) && (left.IsLast == right.IsLast) && (left.Index == right.Index) && (left.NonSpeculativeIndex == right.NonSpeculativeIndex)
+}
+
+func TestPaneCoder(t *testing.T) {
+ tests := []struct {
+ name string
+ timing typex.PaneTiming
+ first bool
+ last bool
+ index int64
+ nsIndex int64
+ }{
+ {
+ "false bools",
+ typex.PaneUnknown,
+ false,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "true bools",
+ typex.PaneUnknown,
+ true,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "first pane",
+ typex.PaneUnknown,
+ true,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "last pane",
+ typex.PaneUnknown,
+ false,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "on time, different index and non-speculative",
+ typex.PaneOnTime,
+ false,
+ false,
+ 1,
+ 2,
+ },
+ {
+ "valid early pane",
+ typex.PaneEarly,
+ true,
+ false,
+ math.MaxInt64,
+ -1,
+ },
+ {
+ "on time, max non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MaxInt64,
+ },
+ {
+ "late pane, max index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MaxInt64,
+ 0,
+ },
+ {
+ "on time, min non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MinInt64,
+ },
+ {
+ "late, min index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MinInt64,
+ 0,
+ },
+ }
+ for _, test := range tests {
+ t.Run(test.name, func(t *testing.T) {
+ input := makePaneInfo(test.timing, test.first, test.last, test.index, test.nsIndex)
+ var buf bytes.Buffer
+ err := EncodePane(input, &buf)
+ if err != nil {
+ t.Fatalf("failed to encode pane %v, got %v", input, err)
+ }
+ got, err := DecodePane(&buf)
+ if err != nil {
+ t.Fatalf("failed to decode pane from buffer %v, got %v", buf, err)
+ }
+ if want := input; !equalPanes(got, want) {
+ t.Errorf("got pane %v, want %v", got, want)
+ }
+ })
+ }
+}
+func TestEncodePane_bad(t *testing.T) {
Review Comment:
```suggestion
func TestEncodePane_bad(t *testing.T) {
```
```suggestion
func TestEncodePane_bad(t *testing.T) {
```
##########
sdks/go/pkg/beam/core/graph/coder/panes_test.go:
##########
@@ -0,0 +1,178 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coder
+
+import (
+ "bytes"
+ "math"
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/typex"
+)
+
+func makePaneInfo(timing typex.PaneTiming, first, last bool, index, nsIndex int64) typex.PaneInfo {
+ return typex.PaneInfo{Timing: timing, IsFirst: first, IsLast: last, Index: index, NonSpeculativeIndex: nsIndex}
+}
+
+func equalPanes(left, right typex.PaneInfo) bool {
+ return (left.Timing == right.Timing) && (left.IsFirst == right.IsFirst) && (left.IsLast == right.IsLast) && (left.Index == right.Index) && (left.NonSpeculativeIndex == right.NonSpeculativeIndex)
+}
+
+func TestPaneCoder(t *testing.T) {
+ tests := []struct {
+ name string
+ timing typex.PaneTiming
+ first bool
+ last bool
+ index int64
+ nsIndex int64
+ }{
+ {
+ "false bools",
+ typex.PaneUnknown,
+ false,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "true bools",
+ typex.PaneUnknown,
+ true,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "first pane",
+ typex.PaneUnknown,
+ true,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "last pane",
+ typex.PaneUnknown,
+ false,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "on time, different index and non-speculative",
+ typex.PaneOnTime,
+ false,
+ false,
+ 1,
+ 2,
+ },
+ {
+ "valid early pane",
+ typex.PaneEarly,
+ true,
+ false,
+ math.MaxInt64,
+ -1,
+ },
+ {
+ "on time, max non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MaxInt64,
+ },
+ {
+ "late pane, max index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MaxInt64,
+ 0,
+ },
+ {
+ "on time, min non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MinInt64,
+ },
+ {
+ "late, min index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MinInt64,
+ 0,
+ },
+ }
+ for _, test := range tests {
+ t.Run(test.name, func(t *testing.T) {
+ input := makePaneInfo(test.timing, test.first, test.last, test.index, test.nsIndex)
+ var buf bytes.Buffer
+ err := EncodePane(input, &buf)
+ if err != nil {
+ t.Fatalf("failed to encode pane %v, got %v", input, err)
+ }
+ got, err := DecodePane(&buf)
+ if err != nil {
+ t.Fatalf("failed to decode pane from buffer %v, got %v", buf, err)
+ }
+ if want := input; !equalPanes(got, want) {
+ t.Errorf("got pane %v, want %v", got, want)
+ }
+ })
+ }
+}
+func TestEncodePane_bad(t *testing.T) {
Review Comment:
```suggestion
func TestEncodePane_bad(t *testing.T) {
```
```suggestion
func TestEncodePane_bad(t *testing.T) {
```
##########
sdks/go/pkg/beam/core/graph/coder/panes_test.go:
##########
@@ -0,0 +1,178 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coder
+
+import (
+ "bytes"
+ "math"
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/typex"
+)
+
+func makePaneInfo(timing typex.PaneTiming, first, last bool, index, nsIndex int64) typex.PaneInfo {
+ return typex.PaneInfo{Timing: timing, IsFirst: first, IsLast: last, Index: index, NonSpeculativeIndex: nsIndex}
+}
+
+func equalPanes(left, right typex.PaneInfo) bool {
+ return (left.Timing == right.Timing) && (left.IsFirst == right.IsFirst) && (left.IsLast == right.IsLast) && (left.Index == right.Index) && (left.NonSpeculativeIndex == right.NonSpeculativeIndex)
+}
+
+func TestPaneCoder(t *testing.T) {
+ tests := []struct {
+ name string
+ timing typex.PaneTiming
+ first bool
+ last bool
+ index int64
+ nsIndex int64
+ }{
+ {
+ "false bools",
+ typex.PaneUnknown,
+ false,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "true bools",
+ typex.PaneUnknown,
+ true,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "first pane",
+ typex.PaneUnknown,
+ true,
+ false,
+ 0,
+ 0,
+ },
+ {
+ "last pane",
+ typex.PaneUnknown,
+ false,
+ true,
+ 0,
+ 0,
+ },
+ {
+ "on time, different index and non-speculative",
+ typex.PaneOnTime,
+ false,
+ false,
+ 1,
+ 2,
+ },
+ {
+ "valid early pane",
+ typex.PaneEarly,
+ true,
+ false,
+ math.MaxInt64,
+ -1,
+ },
+ {
+ "on time, max non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MaxInt64,
+ },
+ {
+ "late pane, max index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MaxInt64,
+ 0,
+ },
+ {
+ "on time, min non-speculative index",
+ typex.PaneOnTime,
+ false,
+ true,
+ 0,
+ math.MinInt64,
+ },
+ {
+ "late, min index",
+ typex.PaneLate,
+ false,
+ false,
+ math.MinInt64,
+ 0,
+ },
+ }
+ for _, test := range tests {
+ t.Run(test.name, func(t *testing.T) {
+ input := makePaneInfo(test.timing, test.first, test.last, test.index, test.nsIndex)
+ var buf bytes.Buffer
+ err := EncodePane(input, &buf)
+ if err != nil {
+ t.Fatalf("failed to encode pane %v, got %v", input, err)
+ }
+ got, err := DecodePane(&buf)
+ if err != nil {
+ t.Fatalf("failed to decode pane from buffer %v, got %v", buf, err)
+ }
+ if want := input; !equalPanes(got, want) {
+ t.Errorf("got pane %v, want %v", got, want)
+ }
+ })
+ }
+}
+func TestEncodePane_bad(t *testing.T) {
Review Comment:
add empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org