You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org> on 2007/10/29 16:46:50 UTC

[jira] Commented: (TRINIDAD-788) stopp uploading empty files

    [ https://issues.apache.org/jira/browse/TRINIDAD-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538526 ] 

Andrew Robinson commented on TRINIDAD-788:
------------------------------------------

0 byte files are very valid, especially on a unix based platform. There are many times that a file by its existence implies meaning. Take for example "~/.config/xserver-xgl/disable", if this file is present, xgl mode of the linux X server is disabled for that user. The file should be empty. This is just one small example.

If an application doesn't want to support 0 byte files, it should use a validator or actionListener method to check the length.

This is different from a blank string in EditableValueHolder. In this instance, the user intentionally uploaded a file with 0 bytes.

I strongly recommend reverting this fix.

> stopp uploading empty files
> ---------------------------
>
>                 Key: TRINIDAD-788
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-788
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>    Affects Versions: 1.0.3-core
>            Reporter: Matthias Weßendorf
>            Assignee: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.0.4-core
>
>
> JSF Spec answers this question:
> "Is an empty String (length 0) equal to "no String" (ie. null)?"
> with yes
> (see required on EditableValueHolder interface)
> the inputFile component should also handle empty files (0 bytes) an no file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.