You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/26 19:54:20 UTC
[GitHub] [incubator-pekko-management] mdedetrich opened a new pull request, #80: Add Scala 3.3 Support
mdedetrich opened a new pull request, #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80
Aside from the expected mechanical work and some additional type ascriptions adding Scala 3 support here wasn't too difficult.
Resolves: https://github.com/apache/incubator-pekko-management/issues/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568442359
> Yes I know, still working on cleaning stuff up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207282983
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
Ah I see what you mean, I thought that `Filter` was an alias for a Scala `Symbol` but in fact it is really checking if its empty. Seems like scalatest added these overloads for symbols which is unusual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568243371
> @mdedetrich I've already solved that on my Scala 3 branch, I'll rebase upon yours
Awesome thanks. I have noticed that your banch seems to have more changes then what is necessary for Scala 3 support?
If so maybe as part of your rebasing only merge what is strictly necessary? Alternatively another way to do this is if you can point me to the fix I can add it to this branch, add co-authorship to you and then when my branch is merged then you can rebase with your additional improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207270838
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
Isn't `shouldBe empty` for an empty collection/option? In this case we are checking for a string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1210276659
##########
lease-kubernetes-int-test/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/LeaseTestSuite.scala:
##########
@@ -47,7 +47,7 @@ object LeaseTestSuite {
case Success(_) if !failed =>
log.info("Test succeeded")
CoordinatedShutdown(as).run(TestPassedReason)
- case Success(_) if failed =>
+ case Success(_) =>
Review Comment:
This is in a test so its not a big problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568361195
@mdedetrich @nvollmar could you agree on which PR we want to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1210217888
##########
lease-kubernetes-int-test/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/LeaseTestSuite.scala:
##########
@@ -47,7 +47,7 @@ object LeaseTestSuite {
case Success(_) if !failed =>
log.info("Test succeeded")
CoordinatedShutdown(as).run(TestPassedReason)
- case Success(_) if failed =>
+ case Success(_) =>
Review Comment:
@nvollmar I just noticed this which seems to be a behaviour change, I will try and revert it and add a suppress warning incase Scala 3 complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207288354
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
Fixed and pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568365462
Yup, I just have some minor syntax fixes (some imports got re-ordered accidentally) but its this one that will be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207279309
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
`val result: List[Filter]` -- shouldn't an 'empty' check work on a List?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207289489
##########
lease-kubernetes/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/LeaseActor.scala:
##########
@@ -19,7 +19,6 @@ import org.apache.pekko
import pekko.actor.Status.Failure
import pekko.actor.{ ActorRef, DeadLetterSuppression, FSM, LoggingFSM, Props }
import pekko.annotation.InternalApi
-import pekko.coordination.lease.kubernetes.LeaseActor._
Review Comment:
This was causing scala 3 to complain about a cyclic reference check hence why it was moved to be inside of `class LeaseActor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568349198
@pjfanning @nvollmar PR is ready to review, note that the entire PR has already passed tests (see https://github.com/mdedetrich/incubator-pekko-management/pull/1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar commented on pull request #80: Add Scala 3.3 Support
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568233956
@mdedetrich I've already solved that on my Scala 3 branch, I'll rebase upon yours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1564917072
@nvollmar Due to how trivial it was to get Scala 3 to compile/test I went ahead and prototyped it to see if there was any potential problems.
While everything is compiling fine, there are tests that fail to pass just on Scala 3, i.e.
```
[error] org.apache.pekko.management.cluster.bootstrap.SelfAwareJoinDeciderSpec
[error] org.apache.pekko.management.cluster.bootstrap.SelfAwareJoinDeciderIPv6Spec
```
I am not that familiar with pekko-management so maybe this is something you can look into to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar commented on pull request #80: Add Scala 3.3 Support
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568272113
I fixed all warnings that popped up and enabled warn as errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207270838
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
Isn't `shouldBe empty` for an empty collection/option? In this case we are checking for a symbol named "empty"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207270070
##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
test("empty string does not break parsing") {
val filters = ""
val result: List[Filter] = parseFiltersString(filters)
- result should be('empty)
+ result should be(Symbol("empty"))
Review Comment:
I think `shouldBe empty` will work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar commented on pull request #80: Add Scala 3.3 Support
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568362487
@pjfanning We already agreed on this one, I applied further changes I did on top of it. I'll close mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568273922
Thanks, I just read the merge commit you made recently in more detail and indeed its an improvement on my run. Running the tests and if its all good I will merge it into this PR and then we can do a squash + merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207275041
##########
management-cluster-bootstrap/src/main/scala/org/apache/pekko/management/cluster/bootstrap/contactpoint/HttpClusterBootstrapRoutes.scala:
##########
@@ -78,6 +78,6 @@ object ClusterBootstrapRequests {
import pekko.http.scaladsl.client.RequestBuilding._
def bootstrapSeedNodes(baseUri: Uri): HttpRequest =
- Get(baseUri + "/bootstrap/seed-nodes")
+ Get(baseUri.toString() + "/bootstrap/seed-nodes")
Review Comment:
```suggestion
Get(s"$baseUri/bootstrap/seed-nodes")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207272694
##########
management-cluster-bootstrap/src/main/scala/org/apache/pekko/management/cluster/bootstrap/contactpoint/HttpClusterBootstrapRoutes.scala:
##########
@@ -78,6 +78,6 @@ object ClusterBootstrapRequests {
import pekko.http.scaladsl.client.RequestBuilding._
def bootstrapSeedNodes(baseUri: Uri): HttpRequest =
- Get(baseUri + "/bootstrap/seed-nodes")
+ Get(baseUri.toString() + "/bootstrap/seed-nodes")
Review Comment:
```suggestion
Get(s"$baseUri/bootstrap/seed-nodes")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207280688
##########
management-cluster-bootstrap/src/main/scala/org/apache/pekko/management/cluster/bootstrap/contactpoint/HttpClusterBootstrapRoutes.scala:
##########
@@ -78,6 +78,6 @@ object ClusterBootstrapRequests {
import pekko.http.scaladsl.client.RequestBuilding._
def bootstrapSeedNodes(baseUri: Uri): HttpRequest =
- Get(baseUri + "/bootstrap/seed-nodes")
+ Get(baseUri.toString() + "/bootstrap/seed-nodes")
Review Comment:
Thanks fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on pull request #80: Add Scala 3.3 Support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568437997
compile issue in https://github.com/apache/incubator-pekko-management/actions/runs/5122076771/jobs/9210637453?pr=80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#issuecomment-1568469707
@pjfanning All issues resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich merged pull request #80: Add Scala 3.3 Support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org