You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/13 05:53:35 UTC

[GitHub] tzulitai commented on a change in pull request #6682: [FLINK-10269] [connectors] Fix Elasticsearch 6 UpdateRequest binary incompatibility

tzulitai commented on a change in pull request #6682: [FLINK-10269] [connectors] Fix Elasticsearch 6 UpdateRequest binary incompatibility
URL: https://github.com/apache/flink/pull/6682#discussion_r217266494
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_streaming_elasticsearch.sh
 ##########
 @@ -45,4 +45,5 @@ $FLINK_DIR/bin/flink run -p 1 $TEST_ES_JAR \
   --index index \
   --type type
 
-verify_result 20 index
+# 40 index requests and 20 final update requests
+verify_result 60 index
 
 Review comment:
   so, is the reason why the e2e tests weren't failing because the incompatibility was only detected on update requests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services