You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pm...@apache.org on 2012/05/07 16:30:13 UTC
js commit: revert to pre-CB-634 version of utils.extend
Updated Branches:
refs/heads/master 2da5b44e4 -> b9ac9a36c
revert to pre-CB-634 version of utils.extend
While refactoring the source for CB-634, I broke utils.extend
by removing it's outer function invocation.
Something about that function still looks wrong, but this
implementation should be the same as before, instead of
the broken version that was introduced in CB-634.
Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/b9ac9a36
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/b9ac9a36
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/b9ac9a36
Branch: refs/heads/master
Commit: b9ac9a36c01b75e4395190739e29883184823e96
Parents: 2da5b44
Author: Patrick Mueller <pm...@apache.org>
Authored: Mon May 7 10:27:05 2012 -0400
Committer: Patrick Mueller <pm...@apache.org>
Committed: Mon May 7 10:27:05 2012 -0400
----------------------------------------------------------------------
lib/common/utils.js | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/b9ac9a36/lib/common/utils.js
----------------------------------------------------------------------
diff --git a/lib/common/utils.js b/lib/common/utils.js
index 97d0934..c5bff13 100644
--- a/lib/common/utils.js
+++ b/lib/common/utils.js
@@ -71,7 +71,7 @@ utils.createUUID = function() {
* Extends a child object from a parent object using classical inheritance
* pattern.
*/
-utils.extend = function() {
+utils.extend = (function() {
// proxy used to establish prototype chain
var F = function() {};
// extend Child from Parent
@@ -81,7 +81,7 @@ utils.extend = function() {
Child.__super__ = Parent.prototype;
Child.prototype.constructor = Child;
};
-}
+}())
/**
* Alerts a message in any available way: alert or console.log.