[jira] [Comment Edited] (HADOOP-12943) Add -w -r options in dfs -test command

["Akira AJISAKA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322970#comment-15322970 ] 

Akira AJISAKA edited comment on HADOOP-12943 at 6/9/16 5:49 PM:
----------------------------------------------------------------

Mostly looks good to me. Thanks [~cheersyang].
{code:title=Test.java}
    } catch (AccessControlException e) {
      return false;
    } catch (FileNotFoundException e) {
      return false;
    }
{code}
Would you use multi-catch statement here? I'm +1 if that is addressed.


was (Author: ajisakaa):
Mostly looks good to me. Thanks [~cheersyang].
{code:Test.java}
    } catch (AccessControlException e) {
      return false;
    } catch (FileNotFoundException e) {
      return false;
    }
{code}
Would you use multi-catch statement here? I'm +1 if that is addressed.

> Add -w -r options in dfs -test command
> --------------------------------------
>
>                 Key: HADOOP-12943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12943
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, scripts, tools
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12943.001.patch, HADOOP-12943.002.patch, HADOOP-12943.003.patch, HADOOP-12943.004.patch
>
>
> Currently the dfs -test command only supports 
>   -d, -e, -f, -s, -z
> options. It would be helpful if we add 
>   -w, -r 
> to verify permission of r/w before actual read or write. This will help script programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org