You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/08/02 20:41:14 UTC
Re: Review Request 61254: SENTRY-1847: Integrate sentry with Hive
2.0.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61254/
-----------------------------------------------------------
(Updated Aug. 2, 2017, 8:41 p.m.)
Review request for sentry and Colm O hEigeartaigh.
Summary (updated)
-----------------
SENTRY-1847: Integrate sentry with Hive 2.0.0
Bugs: SENTRY-1847
https://issues.apache.org/jira/browse/SENTRY-1847
Repository: sentry
Description (updated)
-------
After making appropriate fixes to pom file dependencies for hive-authz profile it was observed that some more code changes are needed to build the code properly with Hive 2.0.0 because of the API changes between Hive 1.1.0 and Hive 2.0.0.
Note: hive-authz2 profile should be used with datanucleus4 profile.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java b29d727
sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java cc0bbec
sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java f173243
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java f173243
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c5a2f42
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/metastore/MetastoreAuthzBindingBaseV2.java 67413fa
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/metastore/SentryMetastorePostEventListenerBaseV2.java 918bf8f
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 9b31b3c
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 85902ed
Diff: https://reviews.apache.org/r/61254/diff/2/
Changes: https://reviews.apache.org/r/61254/diff/1-2/
Testing (updated)
-------
With these changes, code is building with Hive 2.0.0 dependency.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 61254: SENTRY-1847: Integrate sentry with Hive
2.0.0
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61254/#review182102
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 2, 2017, 8:41 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61254/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 8:41 p.m.)
>
>
> Review request for sentry and Colm O hEigeartaigh.
>
>
> Bugs: SENTRY-1847
> https://issues.apache.org/jira/browse/SENTRY-1847
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After making appropriate fixes to pom file dependencies for hive-authz profile it was observed that some more code changes are needed to build the code properly with Hive 2.0.0 because of the API changes between Hive 1.1.0 and Hive 2.0.0.
>
> Note: hive-authz2 profile should be used with datanucleus4 profile.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java b29d727
> sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java cc0bbec
> sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java f173243
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java f173243
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c5a2f42
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/metastore/MetastoreAuthzBindingBaseV2.java 67413fa
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/metastore/SentryMetastorePostEventListenerBaseV2.java 918bf8f
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 9b31b3c
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 85902ed
>
>
> Diff: https://reviews.apache.org/r/61254/diff/2/
>
>
> Testing
> -------
>
> With these changes, code is building with Hive 2.0.0 dependency.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>