You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/03/10 00:35:57 UTC
[GitHub] madlib pull request #240: MLP: Fix step size initialization based on learnin...
GitHub user njayaram2 opened a pull request:
https://github.com/apache/madlib/pull/240
MLP: Fix step size initialization based on learning rate policy
JIRA: MADLIB-1212
The step_size is supposed to be updated based on the learning rate. The
formulae for different policies depend on the current iteration number,
which was not consumed correctly. This commit fixes it by using
it.iteration for the current iteration number in that update.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/mlp-learning-rate-policy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 72c6c8bdf5bfb50132e0566ca9600f82e99b7700
Author: Nandish Jayaram <nj...@...>
Date: 2018-03-06T19:10:50Z
MLP: Fix step size initialization based on learning rate policy
JIRA: MADLIB-1212
The step_size is supposed to be updated based on the learning rate. The
formulae for different policies depend on the current iteration number,
which was not consumed correctly. This commit fixes it by using
it.iteration for the current iteration number in that update.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
----
---
[GitHub] madlib issue #240: MLP: Fix step size initialization based on learning rate ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/240
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/364/
---
[GitHub] madlib pull request #240: MLP: Fix step size initialization based on learnin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/240
---
[GitHub] madlib issue #240: MLP: Fix step size initialization based on learning rate ...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/240
We manually tested the bug fix by printing the step_size and step_size_init for each iteration and then called mlp with all the possible policies.
step_size was updated as expected. +1 for the changes
---
[GitHub] madlib issue #240: MLP: Fix step size initialization based on learning rate ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/240
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/381/
---
[GitHub] madlib pull request #240: MLP: Fix step size initialization based on learnin...
Posted by kaknikhil <gi...@git.apache.org>.
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/240#discussion_r175224785
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -112,6 +112,7 @@ def mlp(schema_madlib, source_table, output_table, independent_varname,
num_output_nodes = 0
classes = []
dependent_type = get_expr_type(dependent_varname, source_table)
+ classes_str = None
--- End diff --
we don't really need this `classes_str` variable, right ?
---