You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/10 19:37:18 UTC
[GitHub] [hudi] vinothchandar commented on a change in pull request #3307: [MINOR] Refactor hive realtime config to extend from HoodieConfig
vinothchandar commented on a change in pull request #3307:
URL: https://github.com/apache/hudi/pull/3307#discussion_r686266391
##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java
##########
@@ -77,10 +78,13 @@ private HoodieMergedLogRecordScanner getMergedLogRecordScanner() throws IOExcept
.withReaderSchema(usesCustomPayload ? getWriterSchema() : getReaderSchema())
.withLatestInstantTime(split.getMaxCommitTime())
.withMaxMemorySizeInBytes(HoodieRealtimeRecordReaderUtils.getMaxCompactionMemoryInBytes(jobConf))
- .withReadBlocksLazily(Boolean.parseBoolean(jobConf.get(HoodieRealtimeConfig.COMPACTION_LAZY_BLOCK_READ_ENABLED_PROP, HoodieRealtimeConfig.DEFAULT_COMPACTION_LAZY_BLOCK_READ_ENABLED)))
+ .withReadBlocksLazily(jobConf.getBoolean(HoodieRealtimeConfig.COMPACTION_LAZY_BLOCK_READ_ENABLED_PROP.key(),
+ HoodieRealtimeConfig.COMPACTION_LAZY_BLOCK_READ_ENABLED_PROP.defaultValue()))
.withReverseReader(false)
- .withBufferSize(jobConf.getInt(HoodieRealtimeConfig.MAX_DFS_STREAM_BUFFER_SIZE_PROP, HoodieRealtimeConfig.DEFAULT_MAX_DFS_STREAM_BUFFER_SIZE))
- .withSpillableMapBasePath(jobConf.get(HoodieRealtimeConfig.SPILLABLE_MAP_BASE_PATH_PROP, HoodieRealtimeConfig.DEFAULT_SPILLABLE_MAP_BASE_PATH))
+ .withBufferSize(jobConf.getInt(HoodieMemoryConfig.MAX_DFS_STREAM_BUFFER_SIZE_PROP.key(),
Review comment:
`HoodieMemoryConfig` has some stuff that is specific to writing, like `WriteStatus` . Can we leave these configs as-is in the `HoodieRealtimeConfig`
##########
File path: hudi-hadoop-mr/pom.xml
##########
@@ -36,6 +36,17 @@
<artifactId>hudi-common</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
hmmm. not sure if we would want `hadoop-mr` depend on the client-common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org