You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/01/07 02:05:00 UTC

[jira] [Commented] (CALCITE-3714) BitString.createFromBytes reverses order of the bits in each byte

    [ https://issues.apache.org/jira/browse/CALCITE-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009291#comment-17009291 ] 

Julian Hyde commented on CALCITE-3714:
--------------------------------------

The method is used from {{SqlLiteral.createBinaryString}}, so I expect that the bug can be reproduced from SQL.

Better to fix it. Also add some tests to {{UtilTest.testBitString}}.

> BitString.createFromBytes reverses order of the bits in each byte
> -----------------------------------------------------------------
>
>                 Key: CALCITE-3714
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3714
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Andrew Pilloud
>            Priority: Trivial
>
> BitString.createFromBytes reverses the order of the bits in each byte. (Passing in 'a' I expect 01100001 but get 10000110.)
> BitString.createFromHexString works as expected, and appears to be the one everyone is using. The "fix" might be to just delete the broken method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)