You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 19:00:30 UTC
svn commit: r1775533 - in /jmeter/trunk/src/components/org/apache/jmeter:
assertions/gui/XPathPanel.java control/gui/ModuleControllerGui.java
extractor/DebugPostProcessor.java sampler/DebugSampler.java
Author: pmouawad
Date: Wed Dec 21 19:00:30 2016
New Revision: 1775533
URL: http://svn.apache.org/viewvc?rev=1775533&view=rev
Log:
Sonar : Fix code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java
jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java
jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessor.java
jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSampler.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java?rev=1775533&r1=1775532&r2=1775533&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java Wed Dec 21 19:00:30 2016
@@ -195,11 +195,7 @@ public class XPathPanel extends JPanel {
Element el = testDoc.createElement("root"); //$NON-NLS-1$
testDoc.appendChild(el);
XPathUtil.validateXPath(testDoc, xpathString);
- } catch (IllegalArgumentException e) {
- log.warn(e.getLocalizedMessage(), e);
- success = false;
- ret = e.getLocalizedMessage();
- } catch (ParserConfigurationException | TransformerException e) {
+ } catch (IllegalArgumentException | ParserConfigurationException | TransformerException e) {
log.warn(e.getLocalizedMessage(), e);
success = false;
ret = e.getLocalizedMessage();
Modified: jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java?rev=1775533&r1=1775532&r2=1775533&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java Wed Dec 21 19:00:30 2016
@@ -38,8 +38,6 @@ import javax.swing.JPanel;
import javax.swing.JPopupMenu;
import javax.swing.JTree;
import javax.swing.SwingConstants;
-import javax.swing.event.TreeSelectionEvent;
-import javax.swing.event.TreeSelectionListener;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
Modified: jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessor.java?rev=1775533&r1=1775532&r2=1775533&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessor.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessor.java Wed Dec 21 19:00:30 2016
@@ -110,9 +110,7 @@ public class DebugPostProcessor extends
String m2 =(String)o2.getKey();
return m1.compareTo(m2);
});
- al.forEach(me -> {
- sb.append(me.getKey()).append("=").append(me.getValue()).append("\n");
- });
+ al.forEach(me -> sb.append(me.getKey()).append("=").append(me.getValue()).append("\n"));
}
public boolean isDisplayJMeterVariables() {
Modified: jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSampler.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSampler.java?rev=1775533&r1=1775532&r2=1775533&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSampler.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSampler.java Wed Dec 21 19:00:30 2016
@@ -95,9 +95,7 @@ public class DebugSampler extends Abstra
String m2 = (String)o2.getKey();
return m1.compareTo(m2);
});
- al.forEach(me -> {
- sb.append(me.getKey()).append("=").append(me.getValue()).append("\n");
- });
+ al.forEach(me -> sb.append(me.getKey()).append("=").append(me.getValue()).append("\n"));
}
public boolean isDisplayJMeterVariables() {