You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/26 16:12:09 UTC

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #63: fix: remove instance from labels

wu-sheng commented on a change in pull request #63:
URL: https://github.com/apache/skywalking-satellite/pull/63#discussion_r696780190



##########
File path: plugins/fetcher/prometheus/metric_family.go
##########
@@ -348,6 +348,7 @@ func isUsefulLabel(mType textparse.MetricType, labelKey string) bool {
 	switch labelKey {
 	case model.MetricNameLabel:
 	case model.InstanceLabel:
+		return false
 	case model.SchemeLabel:
 	case model.MetricsPathLabel:
 	case model.JobLabel:

Review comment:
       Why it is same as service name? I am a little confused.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org