You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/05 03:14:06 UTC
[kudu-CR] subprocess: add server-side metrics
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15367
Change subject: subprocess: add server-side metrics
......................................................................
subprocess: add server-side metrics
This introduces server-side timing information to the list of
subprocess-related metrics.
Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
---
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
4 files changed, 121 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/15367/1
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] subprocess: add server-side metrics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc
File src/kudu/subprocess/echo_subprocess.cc:
http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc@53
PS3, Line 53: METRIC_DEFINE_histogram(server, echo_server_outbound_queue_time_ms,
: "Echo server outbound queue time (ms)",
: kudu::MetricUnit::kMilliseconds,
: "Duration of time in ms spent in the Echo server's outbound request queue",
: kudu::MetricLevel::kInfo,
: 60000LU, 1);
: METRIC_DEFINE_histogram(server, echo_server_inbound_queue_time_ms,
: "Echo server inbound queue time (ms)",
: kudu::MetricUnit::kMilliseconds,
: "Duration of time in ms spent in the Echo server's inbound response queue",
: kudu::MetricLevel::kInfo,
: 60000LU, 1);
Wondering why don't have inbound/outbound queue length metrics on the server side?
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 07:20:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15367
to look at the new patch set (#2).
Change subject: subprocess: add server-side metrics
......................................................................
subprocess: add server-side metrics
This introduces server-side timing information to the list of
subprocess-related metrics.
Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
---
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
4 files changed, 122 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/15367/2
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h
File src/kudu/subprocess/server.h:
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h@57
PS1, Line 57: struct SimpleTimer {
: SimpleTimer() {
: start_time = MonoTime::Now();
: }
: MonoTime start_time;
: MonoDelta elapsed() const {
: return MonoTime::Now() - start_time;
: }
: };
> kudu::StopWatch wasn't simple enough?
Nah, and a bunch of it would go to waste unless I expose more metrics. From util/stopwatch.h
// The implementation relies on several syscalls, so should not be used for
// hot paths, but is useful for timing anything on the granularity of seconds
// or more.
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc
File src/kudu/subprocess/server.cc:
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc@307
PS1, Line 307:
> extra semi-colon.
Done
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/subprocess_proxy-test.cc
File src/kudu/subprocess/subprocess_proxy-test.cc:
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/subprocess_proxy-test.cc@92
PS1, Line 92: #define GET_HIST(metric_entity, metric_name) \
> warning: macro argument should be enclosed in parentheses [bugprone-macro-p
Done
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 06:00:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: add server-side metrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 06:08:51 +0000
Gerrit-HasComments: No
[kudu-CR] subprocess: add server-side metrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h
File src/kudu/subprocess/server.h:
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h@57
PS1, Line 57: struct SimpleTimer {
: SimpleTimer() {
: start_time = MonoTime::Now();
: }
: MonoTime start_time;
: MonoDelta elapsed() const {
: return MonoTime::Now() - start_time;
: }
: };
kudu::StopWatch wasn't simple enough?
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc
File src/kudu/subprocess/server.cc:
http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc@307
PS1, Line 307: ;
extra semi-colon.
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 05:50:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
subprocess: add server-side metrics
This introduces server-side timing information to the list of
subprocess-related metrics.
Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Reviewed-on: http://gerrit.cloudera.org:8080/15367
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
5 files changed, 141 insertions(+), 48 deletions(-)
Approvals:
Hao Hao: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: add server-side metrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 19:19:20 +0000
Gerrit-HasComments: No
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: subprocess: add server-side metrics
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics
......................................................................
Patch Set 3: Verified+1
(1 comment)
Unrelated flake: security-itest
http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc
File src/kudu/subprocess/echo_subprocess.cc:
http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc@53
PS3, Line 53: METRIC_DEFINE_histogram(server, echo_server_outbound_queue_time_ms,
: "Echo server outbound queue time (ms)",
: kudu::MetricUnit::kMilliseconds,
: "Duration of time in ms spent in the Echo server's outbound request queue",
: kudu::MetricLevel::kInfo,
: 60000LU, 1);
: METRIC_DEFINE_histogram(server, echo_server_inbound_queue_time_ms,
: "Echo server inbound queue time (ms)",
: kudu::MetricUnit::kMilliseconds,
: "Duration of time in ms spent in the Echo server's inbound response queue",
: kudu::MetricLevel::kInfo,
: 60000LU, 1);
> Wondering why don't have inbound/outbound queue length metrics on the serve
Yeah, I wasn't sure between showing the length vs showing the size in bytes. I'm happy to include either at some point, but they're not currently available in BlockingQueue, so it's probably worth separating that out into its own patch if we do want one of those metrics.
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Mar 2020 22:13:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: add server-side metrics
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15367
to look at the new patch set (#3).
Change subject: subprocess: add server-side metrics
......................................................................
subprocess: add server-side metrics
This introduces server-side timing information to the list of
subprocess-related metrics.
Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
5 files changed, 141 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/15367/3
--
To view, visit http://gerrit.cloudera.org:8080/15367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179
Gerrit-Change-Number: 15367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)