You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/22 15:31:42 UTC
[GitHub] [druid] AWaterColorPen opened a new pull request #11290: Migrate helm chart from helm v2 to v3
AWaterColorPen opened a new pull request #11290:
URL: https://github.com/apache/druid/pull/11290
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
#### Rename directory from `helm` to `helm/druid`.
- It should place a folder named `druid` under `helm` folder to do **helm package**, just like https://github.com/apache/superset/tree/master/helm/superset
#### Migrate helm chart from helm v2 to v3
- change `apiVersion` from `v1` to `v2`
- migrate dependencies to Chart.yaml
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
cc @asdf2014 @maver1ck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AWaterColorPen commented on a change in pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
AWaterColorPen commented on a change in pull request #11290:
URL: https://github.com/apache/druid/pull/11290#discussion_r637422378
##########
File path: helm/druid/Chart.yaml
##########
@@ -13,10 +13,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-apiVersion: v1
+apiVersion: v2
appVersion: 0.19.0
description: DEPRECATED Apache Druid is a high performance real-time analytics database.
name: druid
+dependencies:
+ - name: zookeeper
+ version: 2.1.4
+ repository: https://charts.helm.sh/incubator
+ condition: zookeeper.enabled
+ - name: mysql
+ version: 1.6.4
+ repository: https://charts.helm.sh/stable
+ condition: mysql.enabled
+ - name: postgresql
+ version: 8.6.4
+ repository: https://charts.helm.sh/stable
+ condition: postgresql.enabled
version: 0.2.18
Review comment:
oh, we need to bump version. BTW, since migrating from v2 to v3, I think we can bump to `0.3.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11290:
URL: https://github.com/apache/druid/pull/11290#issuecomment-850217166
@asdf2014 Can you please check my last comment in the dev thread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #11290:
URL: https://github.com/apache/druid/pull/11290#issuecomment-850219533
Hi, @jihoonson. Sure, let me check it out. Thank you for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 merged pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
asdf2014 merged pull request #11290:
URL: https://github.com/apache/druid/pull/11290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] richardlikeswasabi commented on pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
richardlikeswasabi commented on pull request #11290:
URL: https://github.com/apache/druid/pull/11290#issuecomment-850203949
This is awesome, are there plans to maintain an official Helm chart for Druid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #11290:
URL: https://github.com/apache/druid/pull/11290#issuecomment-850215002
Hi, @richardlikeswasabi. Yep, we are working on it. Before this, @maver1ck @AWaterColorPen and I were the main maintainers of Druid Helm Chart. Now, we maintain this Chart in the Apache Druid main repo, which also facilitates more Druid Helm fans to join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maver1ck commented on a change in pull request #11290: Migrate helm chart from helm v2 to v3
Posted by GitBox <gi...@apache.org>.
maver1ck commented on a change in pull request #11290:
URL: https://github.com/apache/druid/pull/11290#discussion_r637420534
##########
File path: helm/druid/Chart.yaml
##########
@@ -13,10 +13,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-apiVersion: v1
+apiVersion: v2
appVersion: 0.19.0
description: DEPRECATED Apache Druid is a high performance real-time analytics database.
name: druid
+dependencies:
+ - name: zookeeper
+ version: 2.1.4
+ repository: https://charts.helm.sh/incubator
+ condition: zookeeper.enabled
+ - name: mysql
+ version: 1.6.4
+ repository: https://charts.helm.sh/stable
+ condition: mysql.enabled
+ - name: postgresql
+ version: 8.6.4
+ repository: https://charts.helm.sh/stable
+ condition: postgresql.enabled
version: 0.2.18
Review comment:
I think we need to bump version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org